From: David Miller <davem@davemloft.net>
To: jikos@kernel.org
Cc: stephen@networkplumber.org, eric.dumazet@gmail.com,
jhs@mojatatu.com, phil@nwl.cc, xiyou.wangcong@gmail.com,
daniel@iogearbox.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump
Date: Wed, 01 Mar 2017 13:21:44 -0500 (EST) [thread overview]
Message-ID: <20170301.132144.1380602514921591101.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LSU.2.20.1702252226530.24579@cbobk.fhfr.pm>
From: Jiri Kosina <jikos@kernel.org>
Date: Sat, 25 Feb 2017 22:29:09 +0100 (CET)
> @@ -1066,6 +1066,7 @@ hfsc_change_class(struct Qdisc *sch, u32 classid, u32 parentid,
> &pfifo_qdisc_ops, classid);
> if (cl->qdisc == NULL)
> cl->qdisc = &noop_qdisc;
> + qdisc_hash_add(cl->qdisc, true);
> INIT_LIST_HEAD(&cl->children);
> cl->vt_tree = RB_ROOT;
> cl->cf_tree = RB_ROOT;
> @@ -1425,6 +1426,7 @@ hfsc_init_qdisc(struct Qdisc *sch, struct nlattr *opt)
> sch->handle);
> if (q->root.qdisc == NULL)
> q->root.qdisc = &noop_qdisc;
> + qdisc_hash_add(q->root.qdisc, true);
> INIT_LIST_HEAD(&q->root.children);
> q->root.vt_tree = RB_ROOT;
> q->root.cf_tree = RB_ROOT;
I'm not so sure it is legal is potentially pass &noop_qdisc into qdisc_hash_add().
next prev parent reply other threads:[~2017-03-01 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 21:29 [PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump Jiri Kosina
2017-03-01 18:21 ` David Miller [this message]
2017-03-06 11:03 ` Jiri Kosina
2017-03-06 18:35 ` David Miller
2017-03-07 9:59 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301.132144.1380602514921591101.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).