From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: edumazet@google.com, dvyukov@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: net_enable_timestamp() can be called from irq contexts
Date: Wed, 01 Mar 2017 20:58:16 -0800 (PST) [thread overview]
Message-ID: <20170301.205816.1158665690798472665.davem@davemloft.net> (raw)
In-Reply-To: <1488407319.9415.315.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 01 Mar 2017 14:28:39 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> It is now very clear that silly TCP listeners might play with
> enabling/disabling timestamping while new children are added
> to their accept queue.
>
> Meaning net_enable_timestamp() can be called from BH context
> while current state of the static key is not enabled.
>
> Lets play safe and allow all contexts.
>
> The work queue is scheduled only under the problematic cases,
> which are the static key enable/disable transition, to not slow down
> critical paths.
>
> This extends and improves what we did in commit 5fa8bbda38c6 ("net: use
> a work queue to defer net_disable_timestamp() work")
>
> Fixes: b90e5794c5bd ("net: dont call jump_label_dec from irq context")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2017-03-02 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 19:51 net: sleeping function called from invalid context in net_enable_timestamp Dmitry Vyukov
2017-03-01 19:59 ` Eric Dumazet
2017-03-01 20:07 ` Eric Dumazet
2017-03-01 20:11 ` Eric Dumazet
2017-03-01 22:28 ` [PATCH net] net: net_enable_timestamp() can be called from irq contexts Eric Dumazet
2017-03-02 4:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301.205816.1158665690798472665.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).