From: Jiri Pirko <jiri@resnulli.us>
To: Yotam Gigi <yotamg@mellanox.com>
Cc: stephen@networkplumber.org, davem@davemloft.net,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
idosch@mellanox.com, eladr@mellanox.com, jiri@mellanox.com,
roopa@cumulusnetworks.com
Subject: Re: [PATCH net] bridge: Fix error path in nbp_vlan_init
Date: Wed, 1 Mar 2017 20:14:35 +0100 [thread overview]
Message-ID: <20170301191435.GD2365@nanopsycho> (raw)
In-Reply-To: <1488379845-38625-1-git-send-email-yotamg@mellanox.com>
Wed, Mar 01, 2017 at 03:50:45PM CET, yotamg@mellanox.com wrote:
>Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set
>call failes, the vlan_hash wouldn't be destroyed before inited.
>
>Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
>CC: Roopa Prabhu <roopa@cumulusnetworks.com>
>Signed-off-by: Yotam Gigi <yotamg@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2017-03-01 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 14:50 [PATCH net] bridge: Fix error path in nbp_vlan_init Yotam Gigi
2017-03-01 18:25 ` Roopa Prabhu via Bridge
2017-03-01 19:14 ` Jiri Pirko [this message]
2017-03-01 22:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301191435.GD2365@nanopsycho \
--to=jiri@resnulli.us \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox