From: David Miller <davem@davemloft.net>
To: hassan.naveed@imgtec.com
Cc: netdev@vger.kernel.org, paul.burton@imgtec.com,
matt.redfearn@imgtec.com, fw@strlen.de, romieu@fr.zoreil.com
Subject: Re: [PATCH v2] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems
Date: Thu, 02 Mar 2017 13:05:27 -0800 (PST) [thread overview]
Message-ID: <20170302.130527.1814024336719792592.davem@davemloft.net> (raw)
In-Reply-To: <1488334402-13557-1-git-send-email-hassan.naveed@imgtec.com>
From: Hassan Naveed <hassan.naveed@imgtec.com>
Date: Tue, 28 Feb 2017 18:13:22 -0800
> Fix pch_gbe driver for ethernet operations for a big endian CPU.
> Values written to and read from transmit and receive descriptors
> in the pch_gbe driver are byte swapped from the perspective of a
> big endian CPU, since the ethernet controller always operates in
> little endian mode. Rectify this by appropriately byte swapping
> these descriptor field values in the driver software.
>
> Signed-off-by: Hassan Naveed <hassan.naveed@imgtec.com>
> Reviewed-by: Paul Burton <paul.burton@imgtec.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: Paul Burton <paul.burton@imgtec.com>
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Florian Westphal <fw@strlen.de>
> Cc: françois romieu <romieu@fr.zoreil.com>
> ---
> Changes in v2: Additionally changed transmit and receive descriptors field
> types to __le{16,32}. Ran sparse with endianness checking enabled and no
> new warnings were generated.
This doesn't apply cleanly to the 'net' tree, please respin.
prev parent reply other threads:[~2017-03-02 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 2:13 [PATCH v2] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems Hassan Naveed
2017-03-02 21:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302.130527.1814024336719792592.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=hassan.naveed@imgtec.com \
--cc=matt.redfearn@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@imgtec.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).