From: David Miller <davem@davemloft.net>
To: bergwolf@gmail.com
Cc: netdev@vger.kernel.org, jhansen@vmware.com, stefanha@redhat.com,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH-v4-RESEND 1/4] vsock: track pkt owner vsock
Date: Thu, 02 Mar 2017 13:13:03 -0800 (PST) [thread overview]
Message-ID: <20170302.131303.703202861280343181.davem@davemloft.net> (raw)
In-Reply-To: <1488340587-32416-2-git-send-email-bergwolf@gmail.com>
From: Peng Tao <bergwolf@gmail.com>
Date: Wed, 1 Mar 2017 11:56:24 +0800
> So that we can cancel a queued pkt later if necessary.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Peng Tao <bergwolf@gmail.com>
> ---
> include/linux/virtio_vsock.h | 2 ++
> net/vmw_vsock/virtio_transport_common.c | 7 +++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h
> index 9638bfe..193ad3a 100644
> --- a/include/linux/virtio_vsock.h
> +++ b/include/linux/virtio_vsock.h
> @@ -48,6 +48,7 @@ struct virtio_vsock_pkt {
> struct virtio_vsock_hdr hdr;
> struct work_struct work;
> struct list_head list;
> + void *cancel_token; /* only used for cancellation */
The type here is fixed, you only store vhost_sock object pointers
here, so don't use "void *" please.
next prev parent reply other threads:[~2017-03-02 21:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 3:56 [PATCH-v4-RESEND 0/4] vsock: cancel connect packets when failing to connect Peng Tao
2017-03-01 3:56 ` [PATCH-v4-RESEND 1/4] vsock: track pkt owner vsock Peng Tao
2017-03-02 21:13 ` David Miller [this message]
2017-03-03 1:25 ` Peng Tao
2017-03-10 1:48 ` Stefan Hajnoczi
2017-03-01 3:56 ` [PATCH-v4-RESEND 2/4] vhost-vsock: add pkt cancel capability Peng Tao
2017-03-01 3:56 ` [PATCH-v4-RESEND 3/4] vsock: " Peng Tao
2017-03-01 3:56 ` [PATCH-v4-RESEND 4/4] vsock: cancel packets when failing to connect Peng Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302.131303.703202861280343181.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bergwolf@gmail.com \
--cc=jhansen@vmware.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).