From: David Miller <davem@davemloft.net>
To: acme@kernel.org
Cc: netdev@vger.kernel.org, acme@redhat.com,
xiyou.wangcong@gmail.com, edumazet@google.com,
gerrit@erg.abdn.ac.uk, tglx@linutronix.de
Subject: Re: [PATCH 1/2] dccp: Unlock sock before calling sk_free()
Date: Thu, 02 Mar 2017 13:59:20 -0800 (PST) [thread overview]
Message-ID: <20170302.135920.357751469126889997.davem@davemloft.net> (raw)
In-Reply-To: <20170301193508.25760-1-acme@kernel.org>
From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: Wed, 1 Mar 2017 16:35:07 -0300
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> The code where sk_clone() came from created a new socket and locked it,
> but then, on the error path didn't unlock it.
>
> This problem stayed there for a long while, till b0691c8ee7c2 ("net:
> Unlock sock before calling sk_free()") fixed it, but unfortunately the
> callers of sk_clone() (now sk_clone_locked()) were not audited and the
> one in dccp_create_openreq_child() remained.
>
> Now in the age of the syskaller fuzzer, this was finally uncovered, as
> reported by Dmitry:
...
> Fix it just like was done by b0691c8ee7c2 ("net: Unlock sock before calling
> sk_free()").
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Cc: Cong Wang <xiyou.wangcong@gmail.com>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Gerrit Renker <gerrit@erg.abdn.ac.uk>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Link: http://lkml.kernel.org/r/20170301153510.GE15145@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2017-03-02 22:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 19:35 [PATCH 1/2] dccp: Unlock sock before calling sk_free() Arnaldo Carvalho de Melo
2017-03-01 19:35 ` [PATCH 2/2] net: Introduce sk_clone_lock() error path routine Arnaldo Carvalho de Melo
2017-03-02 21:59 ` David Miller
2017-03-03 9:34 ` Sergei Shtylyov
2017-03-02 21:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302.135920.357751469126889997.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=edumazet@google.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).