From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: nico@fluxnic.net, davem@davemloft.net, robert.jarzmik@free.fr,
mugunthanvnm@ti.com, jarod@redhat.com,
felipe.balbi@linux.intel.com, fw@strlen.de,
jeremy.linton@arm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings
Date: Sat, 4 Mar 2017 10:20:17 +0000 [thread overview]
Message-ID: <20170304102017.GS21222@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1488622292-13200-1-git-send-email-tremyfr@gmail.com>
On Sat, Mar 04, 2017 at 11:11:32AM +0100, Philippe Reynes wrote:
>
> // lp->port = cmd->port;
Hi,
Review looks good. However, please also update the above comment as
well.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-03-04 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 10:11 [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Philippe Reynes
2017-03-04 10:20 ` Russell King - ARM Linux [this message]
2017-03-04 20:27 ` Robert Jarzmik
2017-03-04 22:47 ` Philippe Reynes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170304102017.GS21222@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=davem@davemloft.net \
--cc=felipe.balbi@linux.intel.com \
--cc=fw@strlen.de \
--cc=jarod@redhat.com \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=robert.jarzmik@free.fr \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox