From: David Miller <davem@davemloft.net>
To: Jie.Deng1@synopsys.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 net-next] net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet
Date: Tue, 07 Mar 2017 12:34:06 -0800 (PST) [thread overview]
Message-ID: <20170307.123406.1777577205348543307.davem@davemloft.net> (raw)
In-Reply-To: <9c5935b28ca61ec4ceb20bac0cc830e2e57028b9.1488331400.git.jiedeng@synopsys.com>
From: Jie Deng <Jie.Deng1@synopsys.com>
Date: Wed, 1 Mar 2017 12:00:25 +0800
> +static int xlgmac_init(struct xlgmac_pdata *pdata)
> +{
> + struct net_device *netdev = pdata->netdev;
> + struct xlgmac_hw_ops *hw_ops = &pdata->hw_ops;
Please order local variable declarations from longest to shortest line.
Please fix this in your entire submission.
> +
> +err_netdev_register:
> +err_init:
Avoid multiple error labels in the same exact location, by having only
one which describes what the error path unwinds. For example, here you
could say "err_free_netdev".
Please fix this up in your entire submission.
prev parent reply other threads:[~2017-03-07 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 4:00 [PATCH v1 net-next] net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet Jie Deng
2017-03-07 20:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307.123406.1777577205348543307.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jie.Deng1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).