From: David Miller <davem@davemloft.net>
To: tlfalcon@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com,
nfont@linux.vnet.ibm.com, wvoigt@us.ibm.com
Subject: Re: [PATCH 1/2 net] ibmvnic: Fix overflowing firmware/hardware TX queue
Date: Tue, 07 Mar 2017 14:14:44 -0800 (PST) [thread overview]
Message-ID: <20170307.141444.1814957653636898496.davem@davemloft.net> (raw)
In-Reply-To: <1488737922-17305-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Sun, 5 Mar 2017 12:18:41 -0600
> Use a counter to track the number of outstanding transmissions sent
> that have not received completions. If the counter reaches the maximum
> number of queue entries, stop transmissions on that queue. As we receive
> more completions from firmware, wake the queue once the counter reaches
> an acceptable level.
>
> This patch prevents hardware/firmware TX queue from filling up and
> and generating errors. Since incorporating this fix, internal testing
> has reported that these firmware errors have stopped.
>
> Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Applied.
next prev parent reply other threads:[~2017-03-07 22:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 18:18 [PATCH 1/2 net] ibmvnic: Fix overflowing firmware/hardware TX queue Thomas Falcon
2017-03-05 18:18 ` [PATCH 2/2 net] ibmvnic: Allocate number of rx/tx buffers agreed on by firmware Thomas Falcon
2017-03-07 22:14 ` David Miller
2017-03-07 22:14 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-05 18:10 [PATCH 1/2 net] ibmvnic: Fix overflowing firmware/hardware TX queue Thomas Falcon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307.141444.1814957653636898496.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
--cc=wvoigt@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).