From: Stephen Hemminger <stephen@networkplumber.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: alexei.starovoitov@gmail.com, janerik@rediger.net,
netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 master] bpf: test for valid type in bpf_get_work_dir
Date: Wed, 8 Mar 2017 17:57:47 -0800 [thread overview]
Message-ID: <20170308175747.2d235bd5@xeon-e3> (raw)
In-Reply-To: <31298439f86c34288a26fd4c3d2bcac262d37565.1488801657.git.daniel@iogearbox.net>
On Mon, 6 Mar 2017 13:06:00 +0100
Daniel Borkmann <daniel@iogearbox.net> wrote:
> Jan-Erik reported an assertion in bpf_prog_to_subdir() failed where
> type was BPF_PROG_TYPE_UNSPEC, which is only used in bpf_init_env()
> to auto-mount and cache the bpf fs mount point.
>
> Therefore, make sure when bpf_init_env() is called multiple times
> (f.e. eBPF classifier with eBPF action attached) and bpf_mnt_cached
> is set already that the type is also valid. In bpf_init_env(), we're
> only interested in the mount point and not a type-specific subdir.
>
> Fixes: e42256699cac ("bpf: make tc's bpf loader generic and move into lib")
> Reported-by: Jan-Erik Rediger <janerik@rediger.net>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Applied
prev parent reply other threads:[~2017-03-09 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 12:06 [PATCH iproute2 master] bpf: test for valid type in bpf_get_work_dir Daniel Borkmann
2017-03-09 1:57 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308175747.2d235bd5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=janerik@rediger.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).