From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
derek.chickles@cavium.com, satananda.burla@cavium.com,
veerasenareddy.burru@cavium.com
Subject: Re: [PATCH v3 net-next] liquidio: improve UDP TX performance
Date: Thu, 09 Mar 2017 13:08:35 -0800 (PST) [thread overview]
Message-ID: <20170309.130835.1755242052162375234.davem@davemloft.net> (raw)
In-Reply-To: <20170307024559.GA10612@felix.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Mon, 6 Mar 2017 18:45:59 -0800
> Improve UDP TX performance by:
> * reducing the ring size from 2K to 512
> * replacing the numerous streaming DMA allocations for info buffers and
> gather lists with one large consistent DMA allocation per ring
I applied this, because one should always use consistent mappings for
descriptor arrays and things like this, however I am confused about
this:
> Also, finding an empty entry (in rbtree of device domain's iova mapping in
> kernel) during Tx path becomes a bottleneck every so often; the loop to
> find the empty entry goes through over 40K iterations;
A properly balanced tree should not require 40K iterations for a search.
prev parent reply other threads:[~2017-03-09 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 2:45 [PATCH v3 net-next] liquidio: improve UDP TX performance Felix Manlunas
2017-03-09 21:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309.130835.1755242052162375234.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
--cc=veerasenareddy.burru@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).