From: David Miller <davem@davemloft.net>
To: robert.foss@collabora.com
Cc: Yuval.Mintz@cavium.com, Ariel.Elior@cavium.com,
everest-linux-l2@cavium.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v1] qed: Fix copy of uninitialized memory
Date: Thu, 09 Mar 2017 13:18:32 -0800 (PST) [thread overview]
Message-ID: <20170309.131832.1359068981842523227.davem@davemloft.net> (raw)
In-Reply-To: <20170307164625.6372-1-robert.foss@collabora.com>
From: Robert Foss <robert.foss@collabora.com>
Date: Tue, 7 Mar 2017 11:46:25 -0500
> In qed_ll2_start_ooo() the ll2_info variable is uninitialized and then
> passed to qed_ll2_acquire_connection() where it is copied into a new
> memory space.
>
> This shouldn't cause any issue as long as non of the copied memory is
> every read.
> But the potential for a bug being introduced by reading this memory
> is real.
>
> Detected by CoverityScan, CID#1399632 ("Uninitialized scalar variable")
>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
Applied.
prev parent reply other threads:[~2017-03-09 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 16:46 [PATCH RESEND v1] qed: Fix copy of uninitialized memory Robert Foss
2017-03-09 21:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309.131832.1359068981842523227.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@cavium.com \
--cc=Yuval.Mintz@cavium.com \
--cc=everest-linux-l2@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.foss@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).