From: David Miller <davem@davemloft.net>
To: thomas.lendacky@amd.com
Cc: netdev@vger.kernel.org, jeremy.linton@arm.com
Subject: Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true
Date: Thu, 09 Mar 2017 18:31:47 -0800 (PST) [thread overview]
Message-ID: <20170309.183147.1115919481874028502.davem@davemloft.net> (raw)
In-Reply-To: <20170309234823.11010.87592.stgit@tlendack-t1.amdoffice.net>
From: Tom Lendacky <thomas.lendacky@amd.com>
Date: Thu, 9 Mar 2017 17:48:23 -0600
> Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync()
> and enable_irq() when an interrupt is received to process Rx packets. If
> the napi_complete_done() return value isn't checked an unbalanced enable
> for the IRQ could result, generating a warning stack trace.
>
> Update the driver to only enable interrupts if napi_complete_done() returns
> true.
>
> Reported-by: Jeremy Linton <jeremy.linton@arm.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Applied, thanks.
next prev parent reply other threads:[~2017-03-10 2:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 23:48 [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true Tom Lendacky
2017-03-10 2:31 ` David Miller [this message]
2017-03-10 14:19 ` Tom Lendacky
2017-03-10 18:06 ` David Miller
2017-03-10 16:33 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309.183147.1115919481874028502.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeremy.linton@arm.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).