From: Doug Berger <opendmb@gmail.com>
To: f.fainelli@gmail.com
Cc: pgynther@google.com, jaedon.shin@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Edwin Chan <edwin.chan@broadcom.com>,
Doug Berger <doug.berger@broadcom.com>
Subject: [PATCH net 7/8] net: bcmgenet: add begin/complete ethtool ops
Date: Thu, 9 Mar 2017 16:49:05 -0800 [thread overview]
Message-ID: <20170310004906.10553-8-opendmb@gmail.com> (raw)
In-Reply-To: <20170310004906.10553-1-opendmb@gmail.com>
From: Edwin Chan <edwin.chan@broadcom.com>
Make sure clock is enabled for ethtool ops.
refs #SWLINUX-4311
Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
Signed-off-by: Edwin Chan <edwin.chan@broadcom.com>
Signed-off-by: Doug Berger <doug.berger@broadcom.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index f93098840775..ec1f3014e410 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -450,6 +450,22 @@ static inline void bcmgenet_rdma_ring_writel(struct bcmgenet_priv *priv,
genet_dma_ring_regs[r]);
}
+static int bcmgenet_begin(struct net_device *dev)
+{
+ struct bcmgenet_priv *priv = netdev_priv(dev);
+
+ /* Turn on the clock */
+ return clk_prepare_enable(priv->clk);
+}
+
+static void bcmgenet_complete(struct net_device *dev)
+{
+ struct bcmgenet_priv *priv = netdev_priv(dev);
+
+ /* Turn off the clock */
+ clk_disable_unprepare(priv->clk);
+}
+
static int bcmgenet_get_link_ksettings(struct net_device *dev,
struct ethtool_link_ksettings *cmd)
{
@@ -1022,6 +1038,8 @@ static int bcmgenet_set_eee(struct net_device *dev, struct ethtool_eee *e)
/* standard ethtool support functions. */
static const struct ethtool_ops bcmgenet_ethtool_ops = {
+ .begin = bcmgenet_begin,
+ .complete = bcmgenet_complete,
.get_strings = bcmgenet_get_strings,
.get_sset_count = bcmgenet_get_sset_count,
.get_ethtool_stats = bcmgenet_get_ethtool_stats,
--
2.11.1
next prev parent reply other threads:[~2017-03-10 0:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 0:48 [PATCH net 0/8] net: bcmgenet: minor bug fixes Doug Berger
2017-03-10 0:48 ` [PATCH net 1/8] net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_CNT MIB values Doug Berger
2017-03-10 0:49 ` [PATCH net 2/8] net: bcmgenet: correct MIB access of UniMAC RUNT counters Doug Berger
2017-03-10 0:49 ` [PATCH net 3/8] net: bcmgenet: reserved phy revisions must be checked first Doug Berger
2017-03-10 0:49 ` [PATCH net 4/8] net: bcmgenet: power down internal phy if open or resume fails Doug Berger
2017-03-10 0:49 ` [PATCH net 5/8] net: bcmgenet: synchronize irq0 status between the isr and task Doug Berger
2017-03-10 0:49 ` [PATCH net 6/8] net: bcmgenet: Power up the internal PHY before probing the MII Doug Berger
2017-03-10 0:49 ` Doug Berger [this message]
2017-03-10 0:49 ` [PATCH net 8/8] net: bcmgenet: decouple flow control from bcmgenet_tx_reclaim Doug Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310004906.10553-8-opendmb@gmail.com \
--to=opendmb@gmail.com \
--cc=doug.berger@broadcom.com \
--cc=edwin.chan@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).