From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge
Date: Fri, 10 Mar 2017 03:27:48 +0100 [thread overview]
Message-ID: <20170310022748.GI22101@lunn.ch> (raw)
In-Reply-To: <20170309233324.18539-5-vivien.didelot@savoirfairelinux.com>
On Thu, Mar 09, 2017 at 06:33:14PM -0500, Vivien Didelot wrote:
> All Marvell switch chips have an ATU accessed using the same Global (1)
> register layout. Only the handling of the FID differs as more bits were
> necessary to support more and more databases.
>
> Add and use a fresh documented implementation of the ATU Load/Purge.
This is not really the Linux way of doing something. You don't throw
something away and replace it. You incrementally modify what you have
into something better.
I really wished you had moved the code, unmodified, into
global1_atu.c. Then made lots of easy to review small changes. I
cannot just look at this patch and know it is correct. What i need to
compare against is not in this patch. So it is a lot harder to review.
I will continue this review later...
Andrew
next prev parent reply other threads:[~2017-03-10 2:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 23:33 [PATCH net-next 00/14] net: dsa: mv88e6xxx: rework ATU support Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 01/14] net: dsa: mv88e6xxx: add port mask helper Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 02/14] net: dsa: mv88e6xxx: move ATU ageing time setter Vivien Didelot
2017-03-10 0:45 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All Vivien Didelot
2017-03-10 2:00 ` Andrew Lunn
2017-03-10 2:03 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Vivien Didelot
2017-03-10 2:27 ` Andrew Lunn [this message]
2017-03-11 20:55 ` Vivien Didelot
2017-03-11 23:40 ` Andrew Lunn
2017-03-13 14:59 ` Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 05/14] net: dsa: mv88e6xxx: rework ATU GetNext Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 06/14] net: dsa: mv88e6xxx: rework ATU Flush Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove Vivien Didelot
2017-03-10 2:33 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 08/14] net: dsa: mv88e6xxx: rename new FID helper Vivien Didelot
2017-03-10 0:16 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 09/14] net: dsa: mv88e6xxx: rename the port vector member Vivien Didelot
2017-03-10 0:17 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 10/14] net: dsa: mv88e6xxx: rework port mode setup Vivien Didelot
2017-03-10 0:29 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 11/14] net: dsa: mv88e6xxx: fix port egress flooding mode Vivien Didelot
2017-03-09 23:33 ` [PATCH net-next 12/14] net: dsa: mv88e6xxx: add port ATU learn limit op Vivien Didelot
2017-03-10 0:37 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 13/14] net: dsa: mv88e6xxx: add port priority override op Vivien Didelot
2017-03-10 0:39 ` Andrew Lunn
2017-03-09 23:33 ` [PATCH net-next 14/14] etherdevice: remove unused eth_addr_greater Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310022748.GI22101@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).