From: David Miller <davem@davemloft.net>
To: jikos@kernel.org
Cc: stephen@networkplumber.org, eric.dumazet@gmail.com,
jhs@mojatatu.com, phil@nwl.cc, xiyou.wangcong@gmail.com,
daniel@iogearbox.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jiri@resnulli.us
Subject: Re: [PATCH v3 1/2] net: sched: make default fifo qdiscs appear in the dump
Date: Sun, 12 Mar 2017 22:53:26 -0700 (PDT) [thread overview]
Message-ID: <20170312.225326.432231730454919673.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LSU.2.20.1703081602240.31814@cbobk.fhfr.pm>
From: Jiri Kosina <jikos@kernel.org>
Date: Wed, 8 Mar 2017 16:03:32 +0100 (CET)
> From: Jiri Kosina <jkosina@suse.cz>
>
> The original reason [1] for having hidden qdiscs (potential scalability
> issues in qdisc_match_from_root() with single linked list in case of large
> amount of qdiscs) has been invalidated by 59cc1f61f0 ("net: sched: convert
> qdisc linked list to hashtable").
>
> This allows us for bringing more clarity and determinism into the dump by
> making default pfifo qdiscs visible.
>
> We're not turning this on by default though, at it was deemed [2] too
> intrusive / unnecessary change of default behavior towards userspace.
> Instead, TCA_DUMP_INVISIBLE netlink attribute is introduced, which allows
> applications to request complete qdisc hierarchy dump, including the
> ones that have always been implicit/invisible.
>
> Singleton noop_qdisc stays invisible, as teaching the whole infrastructure
> about singletons would require quite some surgery with very little gain
> (seeing no qdisc or seeing noop qdisc in the dump is probably setting
> the same user expectation).
>
> [1] http://lkml.kernel.org/r/1460732328.10638.74.camel@edumazet-glaptop3.roam.corp.google.com
> [2] http://lkml.kernel.org/r/20161021.105935.1907696543877061916.davem@davemloft.net
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Applied, thanks Jiri.
next prev parent reply other threads:[~2017-03-13 5:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 12:03 [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump Jiri Kosina
2017-03-08 14:57 ` Jiri Pirko
2017-03-08 15:03 ` [PATCH v3 " Jiri Kosina
2017-03-13 5:53 ` David Miller [this message]
2017-03-08 15:17 ` [PATCH v2 " Eric Dumazet
2017-03-08 15:21 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170312.225326.432231730454919673.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jikos@kernel.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).