netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, kubakici@wp.pl
Subject: Re: [PATCH net-next 00/13] nfp: XDP adjust head support
Date: Sun, 12 Mar 2017 23:43:35 -0700 (PDT)	[thread overview]
Message-ID: <20170312.234335.1328185272205305351.davem@davemloft.net> (raw)
In-Reply-To: <20170310183839.39568-1-jakub.kicinski@netronome.com>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 10 Mar 2017 10:38:26 -0800

> This series adds support for XDP adjust head.  Bulk of the code
> is actually just paying technical debt.  On reconfiguration request
> nfp was allocating new resources separately leaving device running
> with the existing set of rings.  We used to manage the new resources
> in special ring set structures.  This set is simply separating the
> datapath part of the device structure from the control information
> allowing the new datapath structure to be allocated with all new
> memory and rings.  The swap operation is now greatly simplified.
> We also save a lot of parameter passing this way.  Hopefully the churn
> is worth the negative diffstat.
> 
> Support for XDP adjust head is done in a pretty standard way.  NFP
> is a bit special because it prepends metadata before packet data
> so we have to do a bit of memcpying in case XDP will run.  We also
> luck out a little bit because the fact that we already have prepend
> space allocated means that one byte is enough to store the extra XDP
> space (256 of standard prepend space is a bit inconvenient since
> it would normally require 16bits or boolean with additional shifts).

Series applied, thanks.

      parent reply	other threads:[~2017-03-13  6:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 18:38 [PATCH net-next 00/13] nfp: XDP adjust head support Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 01/13] nfp: separate data path information from the reset of adapter structure Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 02/13] nfp: move control BAR pointer into data path structure Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 03/13] nfp: pass new data path to ring reconfig Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 04/13] nfp: use dp to carry number of stack tx rings and vectors Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 05/13] nfp: use dp to carry fl_bufsz at reconfig time Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 06/13] nfp: use dp to carry mtu " Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 07/13] nfp: use dp to carry xdp_prog " Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 08/13] nfp: switch to using data path structures for reconfiguration Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 09/13] nfp: store dma direction in data path structure Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 10/13] nfp: validate rx offset from the BAR and size down it's field Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 11/13] nfp: reorganize pkt_off variable Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 12/13] nfp: prepare metadata handling for xdp_adjust_head() Jakub Kicinski
2017-03-10 18:38 ` [PATCH net-next 13/13] nfp: add support " Jakub Kicinski
2017-03-13  6:43 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170312.234335.1328185272205305351.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=kubakici@wp.pl \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).