From: Richard Cochran <richardcochran@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Ezequiel Lara Gomez <ezegomez@amazon.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] Enable tx timestamping on loopback and dummy
Date: Sun, 12 Mar 2017 17:30:00 +0100 [thread overview]
Message-ID: <20170312163000.GA1649@localhost.localdomain> (raw)
In-Reply-To: <13e4b635-089d-fb4b-4d73-62b807bb86e8@hartkopp.net>
On Sun, Mar 12, 2017 at 12:17:30AM +0100, Oliver Hartkopp wrote:
> in fact you're doing three different things here:
>
> 1. introduce tx timestamping
> 2. silently change an include: <asm/io.h> -> <linux/io.h>
> 3. fix some whitespace and empty line issues
>
> You'd better provide one patch for 1 & 2 and explain why 2 is needed.
And while you are at it, explain why #1 is needed.
Thanks,
Richard
next prev parent reply other threads:[~2017-03-12 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 14:42 [PATCH] Enable tx timestamping on loopback and dummy Ezequiel Lara Gomez
2017-03-11 15:59 ` Soheil Hassas Yeganeh
2017-03-11 23:17 ` Oliver Hartkopp
2017-03-11 23:37 ` Lara Gomez, Ezequiel
2017-03-12 16:30 ` Richard Cochran [this message]
2017-03-12 20:39 ` Ezequiel Lara Gomez
2017-03-13 10:35 ` Richard Cochran
2017-03-12 21:52 ` [PATCH v3] " Ezequiel Lara Gomez
2017-03-13 10:40 ` Richard Cochran
2017-03-13 11:16 ` [PATCH v4] " Ezequiel Lara Gomez
2017-03-13 19:15 ` David Miller
2017-03-14 10:59 ` [PATCH v5] " Ezequiel Lara Gomez
-- strict thread matches above, loose matches on Subject: below --
2017-03-11 20:28 [PATCH] " Ezequiel Lara Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170312163000.GA1649@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=ezegomez@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).