From: Richard Cochran <richardcochran@gmail.com>
To: Ezequiel Lara Gomez <ezegomez@amazon.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Enable tx timestamping on loopback and dummy
Date: Mon, 13 Mar 2017 11:35:32 +0100 [thread overview]
Message-ID: <20170313103532.GB1875@localhost.localdomain> (raw)
In-Reply-To: <20170312203902.GB23127@u480fcf44e5b8574c5490.ant.amazon.com>
On Sun, Mar 12, 2017 at 08:39:03PM +0000, Ezequiel Lara Gomez wrote:
> On Sun, Mar 12, 2017 at 05:30:00PM +0100, Richard Cochran wrote:
> > And while you are at it, explain why #1 is needed.
>
> Certainly - 2 (and 3) come from checkpatch.pl suggestions
> (I'm mostly following through https://kernelnewbies.org/FirstKernelPatch ),
> so as suggested I've broken them into a separate patch, being
> styling related only (at least according to that script output).
>
> The intent behind 1 is helping developing code that does TX timestamping
> - I lost a good chunk of time toying with it until I realised 127.0.0.1
> could not do TX timestamping because lo did not implement it.
IMHO this is not a very convincing reason, but I won't object if
others agree with this change.
In any case, the motivation belongs in the commit message...
Thanks,
Richard
next prev parent reply other threads:[~2017-03-13 10:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 14:42 [PATCH] Enable tx timestamping on loopback and dummy Ezequiel Lara Gomez
2017-03-11 15:59 ` Soheil Hassas Yeganeh
2017-03-11 23:17 ` Oliver Hartkopp
2017-03-11 23:37 ` Lara Gomez, Ezequiel
2017-03-12 16:30 ` Richard Cochran
2017-03-12 20:39 ` Ezequiel Lara Gomez
2017-03-13 10:35 ` Richard Cochran [this message]
2017-03-12 21:52 ` [PATCH v3] " Ezequiel Lara Gomez
2017-03-13 10:40 ` Richard Cochran
2017-03-13 11:16 ` [PATCH v4] " Ezequiel Lara Gomez
2017-03-13 19:15 ` David Miller
2017-03-14 10:59 ` [PATCH v5] " Ezequiel Lara Gomez
-- strict thread matches above, loose matches on Subject: below --
2017-03-11 20:28 [PATCH] " Ezequiel Lara Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313103532.GB1875@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=ezegomez@amazon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).