* [PATCH net] fjes: Fix wrong netdevice feature flags
@ 2017-03-15 4:47 Taku Izumi
2017-03-15 10:41 ` Sergei Shtylyov
2017-03-15 19:43 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Taku Izumi @ 2017-03-15 4:47 UTC (permalink / raw)
To: netdev, davem; +Cc: yasu.isimatu, Taku Izumi
This patch fixes netdev->features for Extended Socket network device.
Currently Extended Socket network device's netdev->feature claims
NETIF_F_HW_CSUM, however this is completely wrong. There's no feature
of checksum offloading.
That causes invalid TCP/UDP checksum and packet rjection when IP
forwarding from Extended Socket network device to other network device.
NETIF_F_HW_CSUM should be omitted.
Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
---
drivers/net/fjes/fjes_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index b75d9cd..c4b3c4b 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -1316,7 +1316,7 @@ static void fjes_netdev_setup(struct net_device *netdev)
netdev->min_mtu = fjes_support_mtu[0];
netdev->max_mtu = fjes_support_mtu[3];
netdev->flags |= IFF_BROADCAST;
- netdev->features |= NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_CTAG_FILTER;
+ netdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
}
static void fjes_irq_watch_task(struct work_struct *work)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] fjes: Fix wrong netdevice feature flags
2017-03-15 4:47 [PATCH net] fjes: Fix wrong netdevice feature flags Taku Izumi
@ 2017-03-15 10:41 ` Sergei Shtylyov
2017-03-15 19:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2017-03-15 10:41 UTC (permalink / raw)
To: Taku Izumi, netdev, davem; +Cc: yasu.isimatu
Hello!
On 3/15/2017 7:47 AM, Taku Izumi wrote:
> This patch fixes netdev->features for Extended Socket network device.
>
> Currently Extended Socket network device's netdev->feature claims
> NETIF_F_HW_CSUM, however this is completely wrong. There's no feature
> of checksum offloading.
> That causes invalid TCP/UDP checksum and packet rjection when IP
Rejection.
> forwarding from Extended Socket network device to other network device.
>
> NETIF_F_HW_CSUM should be omitted.
>
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] fjes: Fix wrong netdevice feature flags
2017-03-15 4:47 [PATCH net] fjes: Fix wrong netdevice feature flags Taku Izumi
2017-03-15 10:41 ` Sergei Shtylyov
@ 2017-03-15 19:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-03-15 19:43 UTC (permalink / raw)
To: izumi.taku; +Cc: netdev, yasu.isimatu
From: Taku Izumi <izumi.taku@jp.fujitsu.com>
Date: Wed, 15 Mar 2017 13:47:50 +0900
> This patch fixes netdev->features for Extended Socket network device.
>
> Currently Extended Socket network device's netdev->feature claims
> NETIF_F_HW_CSUM, however this is completely wrong. There's no feature
> of checksum offloading.
> That causes invalid TCP/UDP checksum and packet rjection when IP
> forwarding from Extended Socket network device to other network device.
>
> NETIF_F_HW_CSUM should be omitted.
>
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-15 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-15 4:47 [PATCH net] fjes: Fix wrong netdevice feature flags Taku Izumi
2017-03-15 10:41 ` Sergei Shtylyov
2017-03-15 19:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).