From: Jiri Benc <jbenc@redhat.com>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paul Blakey <paulb@mellanox.com>, Roi Dayan <roid@mellanox.com>,
mlxsw@mellanox.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net/openvswitch: Set the ipv6 source tunnel key address attribute correctly
Date: Wed, 15 Mar 2017 17:28:59 +0100 [thread overview]
Message-ID: <20170315172859.6c953e7f@griffin> (raw)
In-Reply-To: <1489594247-8601-1-git-send-email-ogerlitz@mellanox.com>
On Wed, 15 Mar 2017 18:10:47 +0200, Or Gerlitz wrote:
> When dealing with ipv6 source tunnel key address attribute
> (OVS_TUNNEL_KEY_ATTR_IPV6_SRC) we are wrongly setting the tunnel
> dst ip, fix that.
>
> Fixes: 6b26ba3a7d95 ('openvswitch: netlink attributes for IPv6 tunneling')
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> Reported-by: Paul Blakey <paulb@mellanox.com>
Acked-by: Jiri Benc <jbenc@redhat.com>
> Jiri, so I have few wild guesses how things work w.o this fix, e.g:
>
> (1) typically the tunnel source ip attribute isn't set by user-space
I think this is it.
Thanks for the fix!
Jiri
next prev parent reply other threads:[~2017-03-15 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 16:10 [PATCH net] net/openvswitch: Set the ipv6 source tunnel key address attribute correctly Or Gerlitz
2017-03-15 16:28 ` Jiri Benc [this message]
2017-03-15 17:41 ` Joe Stringer
2017-03-15 22:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315172859.6c953e7f@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox