From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Harald Welte <laforge@netfilter.org>
Cc: Jonas Bonn <jonas@southpole.se>,
netdev@vger.kernel.org, osmocom-net-gprs@lists.osmocom.org
Subject: Re: [PATCH 1/1] gtp: support SGSN-side tunnels
Date: Wed, 15 Mar 2017 22:42:33 +0100 [thread overview]
Message-ID: <20170315214233.GA1189@salvia> (raw)
In-Reply-To: <20170315191038.nco2icu6e545rzlu@nataraja>
Hi Harald,
On Wed, Mar 15, 2017 at 08:10:38PM +0100, Harald Welte wrote:
> I've modified the patch slightly, see below (compile-tested, but not
> otherwise tested yet). Basically rename the flags attribute to 'role',
> expand the commit log and removed unrelated cosmetic changes.
>
> I've also prepared a corresponding change to libgtpnl into the
> laforge/sgsn-rol branch, see
> http://git.osmocom.org/libgtpnl/commit/?h=laforge/sgsn-role
>
> This is not yet tested in any way, but I'm planning to add some
> associated support to the command line tools and then give it some
> testing (both against the kernel GTP in GGSN mode, as well as an
> independent userspace GTP implementation).
Thanks Harald.
> > It would be good if we provide a way to configure GTP via iproute2 for
> > testing purposes.
>
> I don't really care about which tool is used, as long as it is easily
> available [and FOSS, of course].
>
> > We would need to create some dummy socket from
> > kernel too though so we don't need any userspace daemon for this
> > testing mode.
>
> I don't really like that latter idea. It sounds too much like a hack to
> me. But then, I don't have enough phantasy right now ti imagine how an
> actual implementation would look like.
It's not that far away, we can just create the udp socket from
kernelspace via udp_sock_create() in the test mode. So we don't need
to pass the file descriptor from userspace. But not asking you to work
on this, just an idea.
> To me, it is perfectly fine to run a simple, small utility in userspace
> even for testing.
No problem.
next prev parent reply other threads:[~2017-03-15 21:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:12 [PATCH 1/1] gtp: support SGSN-side tunnels Jonas Bonn
2017-02-06 11:08 ` Pablo Neira Ayuso
2017-02-06 13:33 ` Jonas Bonn
2017-02-06 14:16 ` Harald Welte
2017-02-06 18:15 ` Pablo Neira Ayuso
2017-02-06 17:27 ` Andreas Schultz
2017-02-06 17:56 ` Pablo Neira Ayuso
2017-02-06 17:25 ` Andreas Schultz
2017-02-06 13:44 ` Harald Welte
2017-02-13 9:25 ` Andreas Schultz
2017-02-13 11:16 ` Pablo Neira Ayuso
2017-02-13 11:52 ` Andreas Schultz
2017-02-13 14:23 ` Harald Welte
2017-03-15 16:39 ` Harald Welte
2017-03-15 17:23 ` Pablo Neira Ayuso
2017-03-15 19:10 ` Harald Welte
2017-03-15 19:27 ` Harald Welte
2017-03-15 21:42 ` Pablo Neira Ayuso [this message]
2017-03-21 15:11 ` Jonas Bonn
2017-03-21 15:04 ` [PATCH v2 1/2] gtp: rename SGSN netlink attribute Jonas Bonn
2017-03-21 15:04 ` [PATCH v2 2/2] gtp: support SGSN-side tunnels Jonas Bonn
2017-03-21 15:07 ` [PATCH v2 1/2] gtp: rename SGSN netlink attribute Pablo Neira Ayuso
2017-03-21 15:10 ` Jonas Bonn
2017-03-21 15:15 ` Pablo Neira Ayuso
2017-03-23 21:16 ` David Miller
2017-03-23 21:28 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315214233.GA1189@salvia \
--to=pablo@netfilter.org \
--cc=jonas@southpole.se \
--cc=laforge@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).