From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RESEND PATCH -net] cpsw/netcp: work around reverse cpts dependency Date: Thu, 16 Mar 2017 20:13:23 -0700 (PDT) Message-ID: <20170316.201323.374866113649500200.davem@davemloft.net> References: <20170313165927.1389014-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: grygorii.strashko@ti.com, tglx@linutronix.de, richardcochran@gmail.com, w-kwok2@ti.com, nicolas.pitre@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: arnd@arndb.de Return-path: In-Reply-To: <20170313165927.1389014-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Arnd Bergmann Date: Mon, 13 Mar 2017 17:59:04 +0100 > The dependency is reversed: cpsw and netcp call into cpts, > but cpts depends on the other two in Kconfig. This can lead > to cpts being a loadable module and its callers built-in: > > drivers/net/ethernet/ti/cpsw.o: In function `cpsw_remove': > cpsw.c:(.text.cpsw_remove+0xd0): undefined reference to `cpts_release' > drivers/net/ethernet/ti/cpsw.o: In function `cpsw_rx_handler': > cpsw.c:(.text.cpsw_rx_handler+0x2dc): undefined reference to `cpts_rx_timestamp' > drivers/net/ethernet/ti/cpsw.o: In function `cpsw_tx_handler': > cpsw.c:(.text.cpsw_tx_handler+0x7c): undefined reference to `cpts_tx_timestamp' > drivers/net/ethernet/ti/cpsw.o: In function `cpsw_ndo_stop': > > As a workaround, I'm introducing another Kconfig symbol to > control the compilation of cpts, while making the actual > module controlled by a silent symbol that is =y when necessary. > > Fixes: 6246168b4a38 ("net: ethernet: ti: netcp: add support of cpts") > Signed-off-by: Arnd Bergmann > Reviewed-by: Grygorii Strashko > --- > Originally submitted on Dec 16, still needed for v4.10 and v4.11-rc2 I'm fine with this change, but please keep the user visible Kconfig symbol name the same, use the new name for the internal one. I know that this means you have to make more changes elsewhere in order to accomplish this.