Re: [Patch net] bridge: resolve a false alarm of lockdep

[David Miller <davem@davemloft.net>]

From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Thu, 16 Mar 2017 19:36:07 +0200

> On 16/03/17 19:32, Cong Wang wrote:
>> Andrei reported a false alarm of lockdep at net/bridge/br_fdb.c:109,
>> this is because in Andrei's case, a spin_bug() was already triggered
>> before this, therefore the debug_locks is turned off, lockdep_is_held()
>> is no longer accurate after that. We should use lockdep_assert_held_once()
>> instead of lockdep_is_held() to respect debug_locks.
>> 
>> Reported-by: Andrei Vagin <avagin@gmail.com>
>> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
>> ---
>>  net/bridge/br_fdb.c     | 2 +-
>>  net/bridge/br_private.h | 9 ---------
>>  2 files changed, 1 insertion(+), 10 deletions(-)
>> 
> 
> Interesting, thanks Cong!
> 
> Fixes: 410b3d48f5111 ("bridge: fdb: add proper lock checks in searching functions")
> 
> Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

Applied, thanks.