From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
roopa@cumulusnetworks.com, dsa@cumulusnetworks.com,
jkbs@redhat.com, edumazet@google.com, pch@ordbogen.com,
nicolas.dichtel@6wind.com
Subject: Re: [PATCH net-next v4] net: ipv4: add support for ECMP hash policy choice
Date: Thu, 16 Mar 2017 09:41:52 -0700 [thread overview]
Message-ID: <20170316094152.0ac70537@xeon-e3> (raw)
In-Reply-To: <1489670880-12717-1-git-send-email-nikolay@cumulusnetworks.com>
On Thu, 16 Mar 2017 15:28:00 +0200
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
> index d6880a6149ee..62c4f94923e5 100644
> --- a/net/ipv4/sysctl_net_ipv4.c
> +++ b/net/ipv4/sysctl_net_ipv4.c
> @@ -1004,6 +1004,15 @@ static struct ctl_table ipv4_net_table[] = {
> .extra1 = &zero,
> .extra2 = &one,
> },
> + {
> + .procname = "fib_multipath_hash_policy",
> + .data = &init_net.ipv4.sysctl_fib_multipath_hash_policy,
> + .maxlen = sizeof(int),
> + .mode = 0644,
> + .proc_handler = proc_dointvec_minmax,
> + .extra1 = &zero,
> + .extra2 = &one,
> +
Rather than having magic integer values, it would be better to use
strings (like TCP congestion control). Especially if you want to support
more values in the future.
Also what about IPv6?
next prev parent reply other threads:[~2017-03-16 16:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 14:59 [PATCH net-next] net: ipv4: add support for ECMP hash policy choice Nikolay Aleksandrov
2017-03-06 16:24 ` David Ahern
2017-03-06 16:52 ` Nikolay Aleksandrov
2017-03-07 6:16 ` Roopa Prabhu
2017-03-07 11:01 ` [PATCH net-next v2] " Nikolay Aleksandrov
2017-03-08 12:05 ` Jakub Sitnicki
2017-03-08 12:43 ` Nikolay Aleksandrov
2017-03-08 16:00 ` Jakub Sitnicki
2017-03-13 2:23 ` David Miller
2017-03-14 15:36 ` [PATCH net-next v3] " Nikolay Aleksandrov
2017-03-14 15:55 ` Stephen Hemminger
2017-03-14 15:58 ` Nikolay Aleksandrov
2017-03-14 18:48 ` David Miller
2017-03-14 20:25 ` Stephen Hemminger
2017-03-14 21:10 ` Roopa Prabhu
2017-03-14 21:42 ` Stephen Hemminger
2017-03-14 22:38 ` Roopa Prabhu
2017-03-14 23:27 ` Stephen Hemminger
2017-03-14 23:45 ` David Ahern
2017-03-15 9:17 ` Nicolas Dichtel
2017-03-15 10:46 ` Nikolay Aleksandrov
2017-03-15 11:18 ` Nicolas Dichtel
2017-03-15 11:27 ` Nikolay Aleksandrov
2017-03-15 15:01 ` David Ahern
2017-03-15 15:20 ` Stephen Hemminger
2017-03-15 0:24 ` David Miller
2017-03-15 2:30 ` Tom Herbert
2017-03-17 3:36 ` David Miller
2017-03-14 18:55 ` Nikolay Aleksandrov
2017-03-15 11:32 ` Jakub Sitnicki
2017-03-15 12:10 ` Nikolay Aleksandrov
2017-03-16 13:28 ` [PATCH net-next v4] " Nikolay Aleksandrov
2017-03-16 16:41 ` Stephen Hemminger [this message]
2017-03-16 16:49 ` Nikolay Aleksandrov
2017-03-17 10:06 ` Nikolay Aleksandrov
2017-03-21 22:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316094152.0ac70537@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=edumazet@google.com \
--cc=jkbs@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=nikolay@cumulusnetworks.com \
--cc=pch@ordbogen.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).