netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Subject: Re: "TCP: eth0: Driver has suspect GRO implementation, TCP performance may be compromised." message with "ethtool -K eth0 gro off"
Date: Sun, 19 Mar 2017 13:14:17 +0100	[thread overview]
Message-ID: <20170319121417.GA293@x4> (raw)
In-Reply-To: <20170206211226.GC3413@localhost.localdomain>

On 2017.02.06 at 19:12 -0200, Marcelo Ricardo Leitner wrote:
> On Fri, Feb 03, 2017 at 06:47:33AM -0800, Eric Dumazet wrote:
> > On Fri, 2017-02-03 at 12:28 -0200, Marcelo Ricardo Leitner wrote:
> > 
> > > Aren't you mixing the endpoints here? MSS is the largest amount of data
> > > that the peer can receive in a single segment, and not how much it will
> > > send. For the sending part, that depends on what the other peer
> > > announced, and we can have 2 different MSS in a single connection, one
> > > for each peer.
> > > 
> > > If a peer later wants to send larger segments, it can, but it must
> > > respect the mss advertised by the other peer during handshake.
> > > 
> > 
> > I am not mixing endpoints, you are.
> > 
> > If you need to be convinced, please grab :
> > https://patchwork.ozlabs.org/patch/723028/
> > 
> > And just watch "ss -temoi ..." 
> 
> I still don't get it, but I also hit the warning on my laptop, using
> iwlwifi. Not sure what I did in order to trigger it, it was by accident.

After many weeks without any warning, I've hit the issue again today:

 TCP: eth0: Driver has suspect GRO implementation, TCP performance may be compromised. rcv_mss:1448 advmss:1448 len:1460

-- 
Markus

  parent reply	other threads:[~2017-03-19 12:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02 11:52 "TCP: eth0: Driver has suspect GRO implementation, TCP performance may be compromised." message with "ethtool -K eth0 gro off" Markus Trippelsdorf
2017-02-02 12:32 ` Eric Dumazet
2017-02-02 12:34   ` Markus Trippelsdorf
2017-02-02 13:31     ` Eric Dumazet
2017-02-02 13:59       ` Eric Dumazet
2017-02-03 11:54         ` Marcelo Ricardo Leitner
2017-02-03 12:06           ` Markus Trippelsdorf
2017-02-03 13:24           ` Eric Dumazet
2017-02-03 13:53             ` Marcelo Ricardo Leitner
2017-02-03 14:16               ` Eric Dumazet
2017-02-03 14:28                 ` Marcelo Ricardo Leitner
2017-02-03 14:47                   ` Eric Dumazet
2017-02-06 21:12                     ` Marcelo Ricardo Leitner
2017-03-10 12:22                       ` Markus Trippelsdorf
2017-03-19 12:14                       ` Markus Trippelsdorf [this message]
2017-03-19 19:20                         ` Eric Dumazet
2017-03-20 19:27                           ` Marcelo Ricardo Leitner
2017-03-22 13:47                             ` Eric Dumazet
2017-03-24 15:56                               ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170319121417.GA293@x4 \
    --to=markus@trippelsdorf.de \
    --cc=eric.dumazet@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).