* liquidio: coverity scan errors
@ 2017-03-20 15:02 Stephen Hemminger
0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2017-03-20 15:02 UTC (permalink / raw)
To: derek.chickles, satananda.burla, felix.manlunas, raghu.vatsavayi; +Cc: netdev
This showed up new Coverity scan erros
** CID 1403160: (FORWARD_NULL)
/drivers/net/ethernet/cavium/liquidio/lio_main.c: 802 in setup_glists()
/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c: 560 in setup_glists()
________________________________________________________________________________________________________
*** CID 1403160: (FORWARD_NULL)
/drivers/net/ethernet/cavium/liquidio/lio_main.c: 802 in setup_glists()
796 */
797 lio->glists_virt_base = kcalloc(num_iqs, sizeof(*lio->glists_virt_base),
798 GFP_KERNEL);
799 lio->glists_dma_base = kcalloc(num_iqs, sizeof(*lio->glists_dma_base),
800 GFP_KERNEL);
801
>>> CID 1403160: (FORWARD_NULL)
>>> Comparing "lio->glists_dma_base" to null implies that "lio->glists_dma_base" might be null.
802 if (!lio->glists_virt_base || !lio->glists_dma_base) {
803 delete_glists(lio);
804 return -ENOMEM;
805 }
806
807 for (i = 0; i < num_iqs; i++) {
/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c: 560 in setup_glists()
554 */
555 lio->glists_virt_base = kcalloc(num_iqs, sizeof(*lio->glists_virt_base),
556 GFP_KERNEL);
557 lio->glists_dma_base = kcalloc(num_iqs, sizeof(*lio->glists_dma_base),
558 GFP_KERNEL);
559
>>> CID 1403160: (FORWARD_NULL)
>>> Comparing "lio->glists_dma_base" to null implies that "lio->glists_dma_base" might be null.
560 if (!lio->glists_virt_base || !lio->glists_dma_base) {
561 delete_glists(lio);
562 return -ENOMEM;
563 }
564
565 for (i = 0; i < num_iqs; i++) {
** CID 1403161: Memory - illegal accesses (OVERRUN)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-20 15:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-20 15:02 liquidio: coverity scan errors Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).