From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, edumazet@google.com, pgynther@google.com,
jaedon.shin@gmail.com, opendmb@gmail.com
Subject: Re: [PATCH net-next] net: bcmgenet: Track per TX/RX rings statistics
Date: Tue, 21 Mar 2017 15:30:34 -0700 (PDT) [thread overview]
Message-ID: <20170321.153034.1285790422123768475.davem@davemloft.net> (raw)
In-Reply-To: <20170316172708.32008-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 16 Mar 2017 10:27:08 -0700
> __bcmgenet_tx_reclaim() is currently summing TX bytes/packets in a way
> that is not SMP friendly, mutliples CPUs could run
> __bcmgenet_tx_reclaim() independently and still update stats->tx_bytes
> and stats->tx_packets, cloberring the other CPUs statistics.
>
> Fix this by tracking per RX and TX rings the number of bytes, packets,
> dropped and errors statistics, and provide a bcmgenet_get_stats()
> function which aggregates everything and returns a consistent output.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2017-03-21 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 17:27 [PATCH net-next] net: bcmgenet: Track per TX/RX rings statistics Florian Fainelli
2017-03-21 22:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321.153034.1285790422123768475.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).