From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: rasesh.mody@cavium.com, kgudipat@brocade.com,
sudarsana.kalluru@cavium.com, Dept-GELinuxNICDev@cavium.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bna: integer overflow bug in debugfs
Date: Tue, 21 Mar 2017 17:43:47 -0700 (PDT) [thread overview]
Message-ID: <20170321.174347.845428848919617726.davem@davemloft.net> (raw)
In-Reply-To: <20170317205234.GA2888@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 17 Mar 2017 23:52:35 +0300
> We could allocate less memory than intended because we do:
>
> bnad->regdata = kzalloc(len << 2, GFP_KERNEL);
>
> The shift can overflow leading to a crash. This is debugfs code so the
> impact is very small.
>
> Fixes: 7afc5dbde091 ("bna: Add debugfs interface.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
prev parent reply other threads:[~2017-03-22 0:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 20:52 [PATCH] bna: integer overflow bug in debugfs Dan Carpenter
2017-03-21 1:14 ` Mody, Rasesh
2017-03-22 0:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321.174347.845428848919617726.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgudipat@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=rasesh.mody@cavium.com \
--cc=sudarsana.kalluru@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).