From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jonas Bonn <jonas@southpole.se>
Cc: laforge@gnumonks.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute
Date: Tue, 21 Mar 2017 16:07:48 +0100 [thread overview]
Message-ID: <20170321150748.GA20384@salvia> (raw)
In-Reply-To: <20170321150430.23314-1-jonas@southpole.se>
On Tue, Mar 21, 2017 at 04:04:29PM +0100, Jonas Bonn wrote:
> diff --git a/include/uapi/linux/gtp.h b/include/uapi/linux/gtp.h
> index 72a04a0..c51ebb0 100644
> --- a/include/uapi/linux/gtp.h
> +++ b/include/uapi/linux/gtp.h
> @@ -19,7 +19,7 @@ enum gtp_attrs {
> GTPA_LINK,
> GTPA_VERSION,
> GTPA_TID, /* for GTPv0 only */
> - GTPA_SGSN_ADDRESS,
> + GTPA_PEER_ADDRESS, /* Remote GSN peer, either SGSN or GGSN */
We need here:
#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS
for backward compatibility. Anything that is exposed through uapi
cannot be changed.
> GTPA_MS_ADDRESS,
> GTPA_FLOW,
> GTPA_NET_NS_FD,
> @@ -29,5 +29,6 @@ enum gtp_attrs {
> __GTPA_MAX,
> };
> #define GTPA_MAX (__GTPA_MAX + 1)
> +#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */
>
> #endif /* _UAPI_LINUX_GTP_H_ */
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-03-21 15:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:12 [PATCH 1/1] gtp: support SGSN-side tunnels Jonas Bonn
2017-02-06 11:08 ` Pablo Neira Ayuso
2017-02-06 13:33 ` Jonas Bonn
2017-02-06 14:16 ` Harald Welte
2017-02-06 18:15 ` Pablo Neira Ayuso
2017-02-06 17:27 ` Andreas Schultz
2017-02-06 17:56 ` Pablo Neira Ayuso
2017-02-06 17:25 ` Andreas Schultz
2017-02-06 13:44 ` Harald Welte
2017-02-13 9:25 ` Andreas Schultz
2017-02-13 11:16 ` Pablo Neira Ayuso
2017-02-13 11:52 ` Andreas Schultz
2017-02-13 14:23 ` Harald Welte
2017-03-15 16:39 ` Harald Welte
2017-03-15 17:23 ` Pablo Neira Ayuso
2017-03-15 19:10 ` Harald Welte
2017-03-15 19:27 ` Harald Welte
2017-03-15 21:42 ` Pablo Neira Ayuso
2017-03-21 15:11 ` Jonas Bonn
2017-03-21 15:04 ` [PATCH v2 1/2] gtp: rename SGSN netlink attribute Jonas Bonn
2017-03-21 15:04 ` [PATCH v2 2/2] gtp: support SGSN-side tunnels Jonas Bonn
2017-03-21 15:07 ` Pablo Neira Ayuso [this message]
2017-03-21 15:10 ` [PATCH v2 1/2] gtp: rename SGSN netlink attribute Jonas Bonn
2017-03-21 15:15 ` Pablo Neira Ayuso
2017-03-23 21:16 ` David Miller
2017-03-23 21:28 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321150748.GA20384@salvia \
--to=pablo@netfilter.org \
--cc=jonas@southpole.se \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).