* [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h
@ 2017-03-20 8:51 Arnd Bergmann
2017-03-20 8:51 ` [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Arnd Bergmann @ 2017-03-20 8:51 UTC (permalink / raw)
To: Jie Deng; +Cc: Arnd Bergmann, David S. Miller, netdev, linux-kernel
Without this header, we can run into a build error:
drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c: In function 'xlgmac_config_queue_mapping':
drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c:1548:36: error: 'IEEE_8021QAZ_MAX_TCS' undeclared (first use in this function)
prio_queues = min_t(unsigned int, IEEE_8021QAZ_MAX_TCS,
Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
index 5cf3e90d4834..1e25a86f6a27 100644
--- a/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
+++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
@@ -22,6 +22,7 @@
#include <linux/clk.h>
#include <linux/bitrev.h>
#include <linux/crc32.h>
+#include <linux/dcbnl.h>
#include "dwc-xlgmac.h"
#include "dwc-xlgmac-reg.h"
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license
2017-03-20 8:51 [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Arnd Bergmann
@ 2017-03-20 8:51 ` Arnd Bergmann
2017-03-21 2:34 ` Jie Deng
2017-03-22 17:53 ` David Miller
2017-03-21 2:22 ` [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Jie Deng
2017-03-22 17:53 ` David Miller
2 siblings, 2 replies; 6+ messages in thread
From: Arnd Bergmann @ 2017-03-20 8:51 UTC (permalink / raw)
To: Jie Deng; +Cc: Arnd Bergmann, David S. Miller, netdev, linux-kernel
When building the driver as a module, we get a warning about the
lack of a license:
WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o
see include/linux/module.h for more information
Curiously the text in the .c files only mentions GPLv2+, while the license
tag in the PCI driver contains both GPL and BSD. I picked the license text
as the more definite reference here and put a GPL tag in there.
Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
index 726d78ac4907..b72196ab647f 100644
--- a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
+++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
@@ -25,6 +25,7 @@
static int debug = -1;
module_param(debug, int, 0644);
+MODULE_LICENSE("GPL");
MODULE_PARM_DESC(debug, "DWC ethernet debug level (0=none,...,16=all)");
static const u32 default_msg_level = (NETIF_MSG_LINK | NETIF_MSG_IFDOWN |
NETIF_MSG_IFUP);
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license
2017-03-20 8:51 ` [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Arnd Bergmann
@ 2017-03-21 2:34 ` Jie Deng
2017-03-22 17:53 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: Jie Deng @ 2017-03-21 2:34 UTC (permalink / raw)
To: Arnd Bergmann, Jie Deng; +Cc: David S. Miller, netdev, linux-kernel
On 2017/3/20 16:51, Arnd Bergmann wrote:
> When building the driver as a module, we get a warning about the
> lack of a license:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o
> see include/linux/module.h for more information
>
> Curiously the text in the .c files only mentions GPLv2+, while the license
> tag in the PCI driver contains both GPL and BSD. I picked the license text
> as the more definite reference here and put a GPL tag in there.
>
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> index 726d78ac4907..b72196ab647f 100644
> --- a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> +++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
> @@ -25,6 +25,7 @@
>
> static int debug = -1;
> module_param(debug, int, 0644);
> +MODULE_LICENSE("GPL");
> MODULE_PARM_DESC(debug, "DWC ethernet debug level (0=none,...,16=all)");
> static const u32 default_msg_level = (NETIF_MSG_LINK | NETIF_MSG_IFDOWN |
> NETIF_MSG_IFUP);
This driver uses dual license. I will update the headers to include BSD. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license
2017-03-20 8:51 ` [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Arnd Bergmann
2017-03-21 2:34 ` Jie Deng
@ 2017-03-22 17:53 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2017-03-22 17:53 UTC (permalink / raw)
To: arnd; +Cc: jiedeng, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 20 Mar 2017 09:51:13 +0100
> When building the driver as a module, we get a warning about the
> lack of a license:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o
> see include/linux/module.h for more information
>
> Curiously the text in the .c files only mentions GPLv2+, while the license
> tag in the PCI driver contains both GPL and BSD. I picked the license text
> as the more definite reference here and put a GPL tag in there.
>
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h
2017-03-20 8:51 [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Arnd Bergmann
2017-03-20 8:51 ` [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Arnd Bergmann
@ 2017-03-21 2:22 ` Jie Deng
2017-03-22 17:53 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: Jie Deng @ 2017-03-21 2:22 UTC (permalink / raw)
To: Arnd Bergmann, Jie Deng; +Cc: David S. Miller, netdev, linux-kernel
On 2017/3/20 16:51, Arnd Bergmann wrote:
> Without this header, we can run into a build error:
>
> drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c: In function 'xlgmac_config_queue_mapping':
> drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c:1548:36: error: 'IEEE_8021QAZ_MAX_TCS' undeclared (first use in this function)
> prio_queues = min_t(unsigned int, IEEE_8021QAZ_MAX_TCS,
>
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
> index 5cf3e90d4834..1e25a86f6a27 100644
> --- a/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
> +++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c
> @@ -22,6 +22,7 @@
> #include <linux/clk.h>
> #include <linux/bitrev.h>
> #include <linux/crc32.h>
> +#include <linux/dcbnl.h>
>
> #include "dwc-xlgmac.h"
> #include "dwc-xlgmac-reg.h"
Thanks.
Reviewed-by: Jie Deng <jiedeng@synopsys.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h
2017-03-20 8:51 [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Arnd Bergmann
2017-03-20 8:51 ` [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Arnd Bergmann
2017-03-21 2:22 ` [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Jie Deng
@ 2017-03-22 17:53 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2017-03-22 17:53 UTC (permalink / raw)
To: arnd; +Cc: jiedeng, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 20 Mar 2017 09:51:12 +0100
> Without this header, we can run into a build error:
>
> drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c: In function 'xlgmac_config_queue_mapping':
> drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c:1548:36: error: 'IEEE_8021QAZ_MAX_TCS' undeclared (first use in this function)
> prio_queues = min_t(unsigned int, IEEE_8021QAZ_MAX_TCS,
>
> Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-22 17:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-20 8:51 [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Arnd Bergmann
2017-03-20 8:51 ` [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license Arnd Bergmann
2017-03-21 2:34 ` Jie Deng
2017-03-22 17:53 ` David Miller
2017-03-21 2:22 ` [PATCH 1/2] [net-next] net: dwc-xlgmac: include dcbnl.h Jie Deng
2017-03-22 17:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).