netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: parthasarathy.bhuvaragan@ericsson.com
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
	jon.maloy@ericsson.com, maloy@donjonn.com,
	ying.xue@windriver.com, thompa.atl@gmail.com
Subject: Re: [PATCH net v1 1/1] tipc: fix nametbl deadlock at tipc_nametbl_unsubscribe
Date: Wed, 22 Mar 2017 11:59:59 -0700 (PDT)	[thread overview]
Message-ID: <20170322.115959.957088455820539447.davem@davemloft.net> (raw)
In-Reply-To: <1490089669-2144-1-git-send-email-parthasarathy.bhuvaragan@ericsson.com>

From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Date: Tue, 21 Mar 2017 10:47:49 +0100

> From: Ying Xue <ying.xue@windriver.com>
> 
> Until now, tipc_nametbl_unsubscribe() is called at subscriptions
> reference count cleanup. Usually the subscriptions cleanup is
> called at subscription timeout or at subscription cancel or at
> subscriber delete.
> 
> We have ignored the possibility of this being called from other
> locations, which causes deadlock as we try to grab the
> tn->nametbl_lock while holding it already.
 ...
> In this commit, we advance the calling of tipc_nametbl_unsubscribe()
> from the refcount cleanup to the intended callers.
> 
> Fixes: d094c4d5f5c7 ("tipc: add subscription refcount to avoid invalid delete")
> Reported-by: John Thompson <thompa.atl@gmail.com>
> Acked-by: Jon Maloy <jon.maloy@ericsson.com>
> Signed-off-by: Ying Xue <ying.xue@windriver.com>
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>

Applied, thank you.

      reply	other threads:[~2017-03-22 19:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  9:47 [PATCH net v1 1/1] tipc: fix nametbl deadlock at tipc_nametbl_unsubscribe Parthasarathy Bhuvaragan
2017-03-22 18:59 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170322.115959.957088455820539447.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jon.maloy@ericsson.com \
    --cc=maloy@donjonn.com \
    --cc=netdev@vger.kernel.org \
    --cc=parthasarathy.bhuvaragan@ericsson.com \
    --cc=thompa.atl@gmail.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).