From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, glider@google.com
Subject: Re: [PATCH net] ipv4: provide stronger user input validation in nl_fib_input()
Date: Wed, 22 Mar 2017 14:18:07 -0700 (PDT) [thread overview]
Message-ID: <20170322.141807.1073258228876112696.davem@davemloft.net> (raw)
In-Reply-To: <1490149348.16816.135.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 21 Mar 2017 19:22:28 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Alexander reported a KMSAN splat caused by reads of uninitialized
> field (tb_id_in) from user provided struct fib_result_nl
>
> It turns out nl_fib_input() sanity tests on user input is a bit
> wrong :
>
> User can pretend nlh->nlmsg_len is big enough, but provide
> at sendmsg() time a too small buffer.
>
> Reported-by: Alexander Potapenko <glider@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2017-03-22 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 2:22 [PATCH net] ipv4: provide stronger user input validation in nl_fib_input() Eric Dumazet
2017-03-22 21:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322.141807.1073258228876112696.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=glider@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).