From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dvyukov@google.com, edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] inet: frag: release spinlock before calling icmp_send()
Date: Wed, 22 Mar 2017 15:41:03 -0700 (PDT) [thread overview]
Message-ID: <20170322.154103.2047938994168800668.davem@davemloft.net> (raw)
In-Reply-To: <1490198235.16816.172.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 22 Mar 2017 08:57:15 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Dmitry reported a lockdep splat [1] (false positive) that we can fix
> by releasing the spinlock before calling icmp_send() from ip_expire()
>
> This is a false positive because sending an ICMP message can not
> possibly re-enter the IP frag engine.
...
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2017-03-22 22:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 13:31 net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov
2017-03-14 14:41 ` Eric Dumazet
2017-03-14 14:46 ` Dmitry Vyukov
2017-03-14 14:56 ` Eric Dumazet
2017-03-14 14:58 ` Dmitry Vyukov
2017-03-14 16:41 ` Cong Wang
2017-03-20 9:59 ` Dmitry Vyukov
2017-03-20 12:43 ` Eric Dumazet
2017-03-14 15:03 ` Paolo Abeni
2017-03-14 15:09 ` Eric Dumazet
2017-03-14 15:34 ` Paolo Abeni
2017-03-22 15:57 ` [PATCH net] inet: frag: release spinlock before calling icmp_send() Eric Dumazet
2017-03-22 22:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322.154103.2047938994168800668.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).