* [patch] sfc: cleanup a condition in efx_udp_tunnel_del()
@ 2017-03-22 9:10 Dan Carpenter
2017-03-22 21:41 ` Jarod Wilson
2017-03-23 2:25 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-03-22 9:10 UTC (permalink / raw)
To: Solarflare linux maintainers
Cc: Edward Cree, Bert Kenward, netdev, kernel-janitors
Presumably if there is an "add" function, there is also a "del"
function. But it causes a static checker warning because it looks like
a common cut and paste bug.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 8c4c273643dc..203c8c3752e7 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2404,7 +2404,7 @@ static void efx_udp_tunnel_del(struct net_device *dev, struct udp_tunnel_info *t
tnl.type = (u16)efx_tunnel_type;
tnl.port = ti->port;
- if (efx->type->udp_tnl_add_port)
+ if (efx->type->udp_tnl_del_port)
(void)efx->type->udp_tnl_del_port(efx, tnl);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] sfc: cleanup a condition in efx_udp_tunnel_del()
2017-03-22 9:10 [patch] sfc: cleanup a condition in efx_udp_tunnel_del() Dan Carpenter
@ 2017-03-22 21:41 ` Jarod Wilson
2017-03-23 2:25 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jarod Wilson @ 2017-03-22 21:41 UTC (permalink / raw)
To: Dan Carpenter, Solarflare linux maintainers
Cc: Edward Cree, Bert Kenward, netdev, kernel-janitors
On 2017-03-22 5:10 AM, Dan Carpenter wrote:
> Presumably if there is an "add" function, there is also a "del"
> function. But it causes a static checker warning because it looks like
> a common cut and paste bug.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Agreed, looks like a cut-n-paste buglet.
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] sfc: cleanup a condition in efx_udp_tunnel_del()
2017-03-22 9:10 [patch] sfc: cleanup a condition in efx_udp_tunnel_del() Dan Carpenter
2017-03-22 21:41 ` Jarod Wilson
@ 2017-03-23 2:25 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-03-23 2:25 UTC (permalink / raw)
To: dan.carpenter; +Cc: linux-net-drivers, ecree, bkenward, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 22 Mar 2017 12:10:02 +0300
> Presumably if there is an "add" function, there is also a "del"
> function. But it causes a static checker warning because it looks like
> a common cut and paste bug.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good, applied, thanks Dan.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-23 2:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-22 9:10 [patch] sfc: cleanup a condition in efx_udp_tunnel_del() Dan Carpenter
2017-03-22 21:41 ` Jarod Wilson
2017-03-23 2:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).