From: David Miller <davem@davemloft.net>
To: w.egorov@phytec.de
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] net: stmmac: dwmac-rk: Add handling for RGMII_ID/RXID/TXID
Date: Wed, 22 Mar 2017 19:32:41 -0700 (PDT) [thread overview]
Message-ID: <20170322.193241.552898718641680618.davem@davemloft.net> (raw)
In-Reply-To: <1490197822-35428-1-git-send-email-w.egorov@phytec.de>
From: Wadim Egorov <w.egorov@phytec.de>
Date: Wed, 22 Mar 2017 16:50:22 +0100
> @@ -74,6 +74,10 @@ struct rk_priv_data {
> #define GRF_BIT(nr) (BIT(nr) | BIT(nr+16))
> #define GRF_CLR_BIT(nr) (BIT(nr+16))
>
> +#define DELAY_ENABLE(soc, tx, rx) \
> + ((tx) ? soc##_GMAC_TXCLK_DLY_ENABLE : soc##_GMAC_TXCLK_DLY_DISABLE | \
> + (rx) ? soc##_GMAC_RXCLK_DLY_ENABLE : soc##_GMAC_RXCLK_DLY_DISABLE)
This doesn't evaluate the way you want it to.
You need to put parenthesis around both "x ? a : b" expressions.
prev parent reply other threads:[~2017-03-23 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 15:50 [PATCH] net: stmmac: dwmac-rk: Add handling for RGMII_ID/RXID/TXID Wadim Egorov
2017-03-23 2:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322.193241.552898718641680618.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).