* [PATCH net] net: phy: Export mdiobus_register_board_info()
@ 2017-03-23 5:40 Florian Fainelli
2017-03-23 7:41 ` Andrew Lunn
2017-03-24 0:14 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2017-03-23 5:40 UTC (permalink / raw)
To: netdev; +Cc: davem, andrew, Florian Fainelli
We can build modular code that uses mdiobus_register_board_info() which would
lead to linking failure since this symbol is not expoerted.
Fixes: 648ea0134069 ("net: phy: Allow pre-declaration of MDIO devices")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/mdio-boardinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/mdio-boardinfo.c b/drivers/net/phy/mdio-boardinfo.c
index 6b988f77da08..61941e29daae 100644
--- a/drivers/net/phy/mdio-boardinfo.c
+++ b/drivers/net/phy/mdio-boardinfo.c
@@ -84,3 +84,4 @@ int mdiobus_register_board_info(const struct mdio_board_info *info,
return 0;
}
+EXPORT_SYMBOL(mdiobus_register_board_info);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: Export mdiobus_register_board_info()
2017-03-23 5:40 [PATCH net] net: phy: Export mdiobus_register_board_info() Florian Fainelli
@ 2017-03-23 7:41 ` Andrew Lunn
2017-03-24 0:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-03-23 7:41 UTC (permalink / raw)
To: Florian Fainelli; +Cc: netdev, davem
On Wed, Mar 22, 2017 at 10:40:30PM -0700, Florian Fainelli wrote:
> We can build modular code that uses mdiobus_register_board_info() which would
> lead to linking failure since this symbol is not expoerted.
>
> Fixes: 648ea0134069 ("net: phy: Allow pre-declaration of MDIO devices")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: Export mdiobus_register_board_info()
2017-03-23 5:40 [PATCH net] net: phy: Export mdiobus_register_board_info() Florian Fainelli
2017-03-23 7:41 ` Andrew Lunn
@ 2017-03-24 0:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-03-24 0:14 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, andrew
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 22 Mar 2017 22:40:30 -0700
> We can build modular code that uses mdiobus_register_board_info() which would
> lead to linking failure since this symbol is not expoerted.
>
> Fixes: 648ea0134069 ("net: phy: Allow pre-declaration of MDIO devices")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-24 0:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23 5:40 [PATCH net] net: phy: Export mdiobus_register_board_info() Florian Fainelli
2017-03-23 7:41 ` Andrew Lunn
2017-03-24 0:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).