From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
derek.chickles@cavium.com, satananda.burla@cavium.com
Subject: Re: [PATCH net-next] liquidio: do not reset Octeon if NIC firmware was preloaded
Date: Fri, 24 Mar 2017 13:20:59 -0700 (PDT) [thread overview]
Message-ID: <20170324.132059.1978744476466250237.davem@davemloft.net> (raw)
In-Reply-To: <20170323202628.GA1090@felix-thinkpad.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Thu, 23 Mar 2017 13:26:28 -0700
> The PF driver is incorrectly resetting Octeon when the module parameter
> "fw_type=none" is there. "fw_type=none" means the PF should not load any
> firmware to the NIC because Octeon is already running preloaded firmware.
>
> Fix it by putting an if (fw_type != none) around the reset code.
>
> Because the Octeon reset is now conditionally gone, when unloading the
> driver, conditionally send the RESET_PF command to the firmware who will
> then free up PF-related data structures.
>
> Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
> Signed-off-by: Satanand Burla <satananda.burla@cavium.com>
Applied.
prev parent reply other threads:[~2017-03-24 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 20:26 [PATCH net-next] liquidio: do not reset Octeon if NIC firmware was preloaded Felix Manlunas
2017-03-24 20:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324.132059.1978744476466250237.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).