From: David Miller <davem@davemloft.net>
To: subashab@codeaurora.org
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
stephen@networkplumber.org, tom@herbertland.com
Subject: Re: [PATCH net-next v5] net: Add sysctl to toggle early demux for tcp and udp
Date: Fri, 24 Mar 2017 13:21:06 -0700 (PDT) [thread overview]
Message-ID: <20170324.132106.869851609280213495.davem@davemloft.net> (raw)
In-Reply-To: <1490297656-31068-1-git-send-email-subashab@codeaurora.org>
From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Date: Thu, 23 Mar 2017 13:34:16 -0600
> Certain system process significant unconnected UDP workload.
> It would be preferrable to disable UDP early demux for those systems
> and enable it for TCP only.
>
> By disabling UDP demux, we see these slight gains on an ARM64 system-
> 782 -> 788Mbps unconnected single stream UDPv4
> 633 -> 654Mbps unconnected UDPv4 different sources
>
> The performance impact can change based on CPU architecure and cache
> sizes. There will not much difference seen if entire UDP hash table
> is in cache.
>
> Both sysctls are enabled by default to preserve existing behavior.
>
> v1->v2: Change function pointer instead of adding conditional as
> suggested by Stephen.
>
> v2->v3: Read once in callers to avoid issues due to compiler
> optimizations. Also update commit message with the tests.
>
> v3->v4: Store and use read once result instead of querying pointer
> again incorrectly.
>
> v4->v5: Refactor to avoid errors due to compilation with IPV6={m,n}
>
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
> Suggested-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2017-03-24 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 19:34 [PATCH net-next v5] net: Add sysctl to toggle early demux for tcp and udp Subash Abhinov Kasiviswanathan
2017-03-24 20:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324.132106.869851609280213495.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=subashab@codeaurora.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).