* [net] Revert "e1000e: driver trying to free already-free irq"
@ 2017-03-24 3:47 Jeff Kirsher
2017-03-24 3:57 ` Jeff Kirsher
2017-03-24 20:44 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Kirsher @ 2017-03-24 3:47 UTC (permalink / raw)
To: davem; +Cc: Jeff Kirsher, netdev, nhorman, sassmann, jogreene
This reverts commit 7e54d9d063fa239c95c21548c5267f0ef419ff56.
After additional regression testing, several users are experiencing
kernel panics during shutdown on e1000e devices. Reverting this
change resolves the issue.
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 2175cced402f..e9af89ad039c 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -6274,8 +6274,8 @@ static int e1000e_pm_freeze(struct device *dev)
/* Quiesce the device without resetting the hardware */
e1000e_down(adapter, false);
e1000_free_irq(adapter);
- e1000e_reset_interrupt_capability(adapter);
}
+ e1000e_reset_interrupt_capability(adapter);
/* Allow time for pending master requests to run */
e1000e_disable_pcie_master(&adapter->hw);
--
2.12.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net] Revert "e1000e: driver trying to free already-free irq"
2017-03-24 3:47 [net] Revert "e1000e: driver trying to free already-free irq" Jeff Kirsher
@ 2017-03-24 3:57 ` Jeff Kirsher
2017-03-24 20:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Kirsher @ 2017-03-24 3:57 UTC (permalink / raw)
To: davem, stable; +Cc: netdev, nhorman, sassmann, jogreene
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
On Thu, 2017-03-23 at 20:47 -0700, Jeff Kirsher wrote:
> This reverts commit 7e54d9d063fa239c95c21548c5267f0ef419ff56.
>
> After additional regression testing, several users are experiencing
> kernel panics during shutdown on e1000e devices. Reverting this
> change resolves the issue.
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
CC: <stable@vger.kernel.org>
Sorry, meant to queue this up for stable as well.
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
> b/drivers/net/ethernet/intel/e1000e/netdev.c
> index 2175cced402f..e9af89ad039c 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -6274,8 +6274,8 @@ static int e1000e_pm_freeze(struct device *dev)
> /* Quiesce the device without resetting the hardware
> */
> e1000e_down(adapter, false);
> e1000_free_irq(adapter);
> - e1000e_reset_interrupt_capability(adapter);
> }
> + e1000e_reset_interrupt_capability(adapter);
>
> /* Allow time for pending master requests to run */
> e1000e_disable_pcie_master(&adapter->hw);
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net] Revert "e1000e: driver trying to free already-free irq"
2017-03-24 3:47 [net] Revert "e1000e: driver trying to free already-free irq" Jeff Kirsher
2017-03-24 3:57 ` Jeff Kirsher
@ 2017-03-24 20:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-03-24 20:44 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, nhorman, sassmann, jogreene
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 23 Mar 2017 20:47:15 -0700
> This reverts commit 7e54d9d063fa239c95c21548c5267f0ef419ff56.
>
> After additional regression testing, several users are experiencing
> kernel panics during shutdown on e1000e devices. Reverting this
> change resolves the issue.
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-24 20:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-24 3:47 [net] Revert "e1000e: driver trying to free already-free irq" Jeff Kirsher
2017-03-24 3:57 ` Jeff Kirsher
2017-03-24 20:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).