From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org, soheil@google.com, edumazet@google.com,
ncardwell@google.com, ycheng@google.com
Subject: Re: [PATCH net] secure_seq: downgrade to per-host timestamp offsets
Date: Fri, 24 Mar 2017 19:28:26 -0700 (PDT) [thread overview]
Message-ID: <20170324.192826.11282993769447164.davem@davemloft.net> (raw)
In-Reply-To: <20170324184237.16044-1-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Fri, 24 Mar 2017 19:42:37 +0100
> Unfortunately too many devices (not under our control) use tcp_tw_recycle=1,
> which depends on timestamps being identical of the same saddr.
>
> Although tcp_tw_recycle got removed in net-next we can't make
> such end hosts disappear so downgrade to per-host timestamp offsets.
>
> Cc: Soheil Hassas Yeganeh <soheil@google.com>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Neal Cardwell <ncardwell@google.com>
> Cc: Yuchung Cheng <ycheng@google.com>
> Reported-by: Yvan Vanrossomme <yvan@vanrossomme.net>
> Fixes: 95a22caee396c ("tcp: randomize tcp timestamp offsets for each connection")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Ok, applied and queued up for -stable.
> David, I can cook a stable patch using jhash if needed, just let me know
> (siphash was added after 4.10).
Yes, I'll need that, thanks!
prev parent reply other threads:[~2017-03-25 2:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 18:42 [PATCH net] secure_seq: downgrade to per-host timestamp offsets Florian Westphal
2017-03-25 2:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324.192826.11282993769447164.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).