netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2
@ 2017-03-24  1:02 David Ahern
  2017-03-24 10:05 ` Robert Shearman
  2017-03-24 20:29 ` David Miller
  0 siblings, 2 replies; 6+ messages in thread
From: David Ahern @ 2017-03-24  1:02 UTC (permalink / raw)
  To: netdev; +Cc: rshearma, David Ahern

Fix copy and paste error setting rt_ttl_propagate.

Fixes: 5b441ac8784c1 ("mpls: allow TTL propagation to IP packets to be configured")
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
 net/mpls/af_mpls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 82589b2abf3c..cd8be8d5e4ad 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -1949,7 +1949,7 @@ static int resize_platform_label_table(struct net *net, size_t limit)
 		RCU_INIT_POINTER(rt2->rt_nh->nh_dev, lo);
 		rt2->rt_protocol = RTPROT_KERNEL;
 		rt2->rt_payload_type = MPT_IPV6;
-		rt0->rt_ttl_propagate = MPLS_TTL_PROP_DEFAULT;
+		rt2->rt_ttl_propagate = MPLS_TTL_PROP_DEFAULT;
 		rt2->rt_nh->nh_via_table = NEIGH_LINK_TABLE;
 		rt2->rt_nh->nh_via_alen = lo->addr_len;
 		memcpy(__mpls_nh_via(rt2, rt2->rt_nh), lo->dev_addr,
-- 
2.10.1 (Apple Git-78)

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2
  2017-03-24  1:02 [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2 David Ahern
@ 2017-03-24 10:05 ` Robert Shearman
  2017-03-24 20:29 ` David Miller
  1 sibling, 0 replies; 6+ messages in thread
From: Robert Shearman @ 2017-03-24 10:05 UTC (permalink / raw)
  To: David Ahern, netdev

On 24/03/17 01:02, David Ahern wrote:
> Fix copy and paste error setting rt_ttl_propagate.
>
> Fixes: 5b441ac8784c1 ("mpls: allow TTL propagation to IP packets to be configured")
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>

Good catch.

Acked-by: Robert Shearman <rshearma@brocade.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2
  2017-03-24  1:02 [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2 David Ahern
  2017-03-24 10:05 ` Robert Shearman
@ 2017-03-24 20:29 ` David Miller
  2017-03-24 20:32   ` David Ahern
  1 sibling, 1 reply; 6+ messages in thread
From: David Miller @ 2017-03-24 20:29 UTC (permalink / raw)
  To: dsa; +Cc: netdev, rshearma

From: David Ahern <dsa@cumulusnetworks.com>
Date: Thu, 23 Mar 2017 19:02:27 -0600

> Fix copy and paste error setting rt_ttl_propagate.
> 
> Fixes: 5b441ac8784c1 ("mpls: allow TTL propagation to IP packets to be configured")
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2
  2017-03-24 20:29 ` David Miller
@ 2017-03-24 20:32   ` David Ahern
  2017-03-24 21:11     ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: David Ahern @ 2017-03-24 20:32 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, rshearma

On 3/24/17 2:29 PM, David Miller wrote:
> From: David Ahern <dsa@cumulusnetworks.com>
> Date: Thu, 23 Mar 2017 19:02:27 -0600
> 
>> Fix copy and paste error setting rt_ttl_propagate.
>>
>> Fixes: 5b441ac8784c1 ("mpls: allow TTL propagation to IP packets to be configured")
>> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
> 
> Applied.
> 

Hi Dave: are you planning to merge net into net-next in the next few
days? I have more MPLS patches for net-next but I know there are
conflicts with changes in net. Wanted to get those patch sets out before
netdev week.

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2
  2017-03-24 20:32   ` David Ahern
@ 2017-03-24 21:11     ` David Miller
  2017-03-24 21:36       ` David Ahern
  0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2017-03-24 21:11 UTC (permalink / raw)
  To: dsa; +Cc: netdev, rshearma

From: David Ahern <dsa@cumulusnetworks.com>
Date: Fri, 24 Mar 2017 14:32:42 -0600

> On 3/24/17 2:29 PM, David Miller wrote:
>> From: David Ahern <dsa@cumulusnetworks.com>
>> Date: Thu, 23 Mar 2017 19:02:27 -0600
>> 
>>> Fix copy and paste error setting rt_ttl_propagate.
>>>
>>> Fixes: 5b441ac8784c1 ("mpls: allow TTL propagation to IP packets to be configured")
>>> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
>> 
>> Applied.
>> 
> 
> Hi Dave: are you planning to merge net into net-next in the next few
> days? I have more MPLS patches for net-next but I know there are
> conflicts with changes in net. Wanted to get those patch sets out before
> netdev week.

I did a merge yesterday, so I am not likely to do another for about a week.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2
  2017-03-24 21:11     ` David Miller
@ 2017-03-24 21:36       ` David Ahern
  0 siblings, 0 replies; 6+ messages in thread
From: David Ahern @ 2017-03-24 21:36 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, rshearma

On 3/24/17 3:11 PM, David Miller wrote:
> I did a merge yesterday, so I am not likely to do another for about a week.

hmmm.... some how I missed it. That merge has what I need.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-03-24 21:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-24  1:02 [PATCH net-next] net: mpls: Fix setting ttl_propagate for rt2 David Ahern
2017-03-24 10:05 ` Robert Shearman
2017-03-24 20:29 ` David Miller
2017-03-24 20:32   ` David Ahern
2017-03-24 21:11     ` David Miller
2017-03-24 21:36       ` David Ahern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).