From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Harald Welte <laforge@gnumonks.org>
Cc: Jonas Bonn <jonas@southpole.se>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/2] GTP SGSN-side tunnels
Date: Fri, 24 Mar 2017 12:23:18 +0100 [thread overview]
Message-ID: <20170324112318.GA1946@salvia> (raw)
In-Reply-To: <20170324101525.5i26wlg5jbsp6qrh@nataraja>
On Fri, Mar 24, 2017 at 11:15:25AM +0100, Harald Welte wrote:
> Hi Jonas,
>
> looks fine to me, but I haven't tested it. Did you manually test it
> using the extended libgtpnl + tools?
>
> Also, in code like this:
>
> + if (gtp->role == GTP_ROLE_SGSN) {
> + pctx = ipv4_pdp_find(gtp, iph->saddr);
> + } else {
>
> I think general Linux kernel coding style is to not have curly-brackets
> around single-line blocks. See "Do not unnecessarily use braces where a
> single statement will do." in line 169 of
> Documentation/process/coding-style.rst
>
> I won't mind your current style, and it is not a blocker issue to me,
> but still it would be nice for general consistency.
Harald is right, I overlook this comestic thing.
next prev parent reply other threads:[~2017-03-24 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 9:33 [PATCH net-next v3 0/2] GTP SGSN-side tunnels Jonas Bonn
2017-03-24 9:33 ` [PATCH net-next v3 1/2] gtp: rename SGSN netlink attribute Jonas Bonn
2017-03-24 9:33 ` [PATCH net-next v3 2/2] gtp: support SGSN-side tunnels Jonas Bonn
2017-03-24 10:15 ` [PATCH net-next v3 0/2] GTP " Harald Welte
2017-03-24 11:23 ` Pablo Neira Ayuso [this message]
2017-03-24 11:59 ` Sergei Shtylyov
2017-03-24 13:46 ` Jonas Bonn
2017-03-24 10:41 ` Pablo Neira Ayuso
2017-03-24 13:57 ` Jonas Bonn
2017-03-24 18:25 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324112318.GA1946@salvia \
--to=pablo@netfilter.org \
--cc=jonas@southpole.se \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).