netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: [PATCH RFC v2 0/3] phylib EEE updates
Date: Mon, 27 Mar 2017 10:58:26 +0100	[thread overview]
Message-ID: <20170327095826.GA2310@n2100.armlinux.org.uk> (raw)

Florian,

This series of patches depends on the previous set of changes, and is
therefore net-next material.

While testing the EEE code, I discovered a number of issues:

1. It is possible to enable advertisment of EEE modes which are not
   supported by the hardware.  We omit to check the supported modes
   and mask off those modes that are not supported before writing the
   EEE advertisment register.

2. We need to restart autonegotiation after a change of the EEE
   advertisment, otherwise the link partner does not see the updated
   EEE modes.

3. SGMII connected PHYs are also capable of supporting EEE.

I'm not too sure why we have the test in phylib for the interface mode,
as the list of interface modes that support EEE is likely to increase
(eg, 10G interface modes have provision to support EEE mode.)  I did
think about killing the test, but the older interface modes probably
don't support it.  Any thoughts on what to do about that - maybe the
test should be reversed to exclude those modes which definitely don't
support EEE?

 drivers/net/phy/phy.c | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

v2: fix "phy_restart_aneg" build error identified by 0-day
   
-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

             reply	other threads:[~2017-03-27  9:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  9:58 Russell King - ARM Linux [this message]
2017-03-27  9:58 ` [PATCH RFC v2 1/3] net: phy: avoid setting unsupported EEE advertisments Russell King
2017-03-27 18:04   ` Florian Fainelli
2017-03-27  9:58 ` [PATCH RFC v2 2/3] net: phy: restart phy autonegotiation after EEE advertisment change Russell King
2017-03-27 18:03   ` Florian Fainelli
2017-03-27  9:59 ` [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes Russell King
2017-03-27 16:47   ` Florian Fainelli
2017-03-27 17:00     ` Russell King - ARM Linux
2017-03-27 18:03       ` Florian Fainelli
2017-03-27 19:47         ` Russell King - ARM Linux
2017-03-27 19:48           ` Florian Fainelli
2017-03-27 20:15             ` Russell King - ARM Linux
2017-03-27 22:42               ` Florian Fainelli
2017-03-27 22:47                 ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327095826.GA2310@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).