From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corentin Labbe Subject: Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll Date: Mon, 27 Mar 2017 20:43:45 +0200 Message-ID: <20170327184345.GB8441@Red> References: <20170325072621.GA20997@Red> <74765cbf-897a-67a1-7f42-337bf7dff6a8@synopsys.com> <20170327170058.GA8441@Red> <17236ff7-a83e-9506-9744-3570e51a6da9@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: davem@davemloft.net, peppe.cavallaro@st.com, alexandre.torgue@st.com, thierry.reding@gmail.com, sergei.shtylyov@cogentembedded.com, f.fainelli@gmail.com, niklas.cassel@axis.com, netdev@vger.kernel.org To: Joao Pinto Return-path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:34747 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbdC0SoS (ORCPT ); Mon, 27 Mar 2017 14:44:18 -0400 Received: by mail-wr0-f193.google.com with SMTP id w43so13003352wrb.1 for ; Mon, 27 Mar 2017 11:43:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <17236ff7-a83e-9506-9744-3570e51a6da9@synopsys.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Mar 27, 2017 at 06:06:05PM +0100, Joao Pinto wrote: > Ās 6:00 PM de 3/27/2017, Corentin Labbe escreveu: > > On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: > >> Hi David, > >> > >> Ās 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > >>> On Fri, Mar 24, 2017 at 05:16:45PM +0000, Joao Pinto wrote: > >>>> For cores that have more than 1 TX queue configured, the kernel would crash, > >>>> since only one TX queue is permitted by default. > >>>> > >>>> Signed-off-by: Joao Pinto > >>>> --- > >>>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > >>>> index 3827952..1eab084 100644 > >>>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > >>>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > >>>> @@ -3429,7 +3429,7 @@ static int stmmac_poll(struct napi_struct *napi, int budget) > >>>> struct stmmac_rx_queue *rx_q = > >>>> container_of(napi, struct stmmac_rx_queue, napi); > >>>> struct stmmac_priv *priv = rx_q->priv_data; > >>>> - u32 tx_count = priv->dma_cap.number_tx_queues; > >>>> + u32 tx_count = priv->plat->tx_queues_to_use; > >>>> u32 chan = rx_q->queue_index; > >>>> u32 work_done = 0; > >>>> u32 queue = 0; > >>>> -- > >>>> 2.9.3 > >>>> > >>> > >>> This patch fix the performance issue on dwmac-sun8i only. > >>> The dwmac-sunxi is still broken. > >>> > >> > >> This patch series can be upstreamed please, since they make 2 fixes, one of them > >> solving the problem in dwmac-sun8i. > >> > >> Thanks. > > > > As I said in a previous answer, finaly dwmac-sun8i is still broken. > > Adding thoses 2 patch will just made the revert harder. > > Oh, ok. You are using version >=4.00 or older versions? > older for both