From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, andrew@lunn.ch, rmk+kernel@armlinux.org.uk,
Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH RFC net-next 3/3] net: phy: stop the PHY clock during LPI only if supported
Date: Mon, 27 Mar 2017 11:47:21 -0700 [thread overview]
Message-ID: <20170327184721.30275-4-f.fainelli@gmail.com> (raw)
In-Reply-To: <20170327184721.30275-1-f.fainelli@gmail.com>
Now that we detect whether a PHY supports stopping its clock during LPI,
deny a call to phy_init_eee() with clk_stop_enable being set and the PHY
not supporting that.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index ba4676ee9018..1c3800e01d82 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -1251,7 +1251,7 @@ int phy_init_eee(struct phy_device *phydev, bool clk_stop_enable)
if (!phy_check_valid(phydev->speed, phydev->duplex, lp & adv))
goto eee_exit_err;
- if (clk_stop_enable) {
+ if (clk_stop_enable && phydev->clk_stop_cap) {
/* Configure the PHY to stop receiving xMII
* clock while it is signaling LPI.
*/
--
2.9.3
next prev parent reply other threads:[~2017-03-27 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 18:47 [PATCH RFC net-next 0/3] net: phy: Read if PHY can stop its clock Florian Fainelli
2017-03-27 18:47 ` [PATCH RFC net-next 1/3] net: mdio: add definition for MDIO_STAT1_CLOCK_STOP_CAPABLE Florian Fainelli
2017-03-27 18:47 ` [PATCH RFC net-next 2/3] net: phy: read whether PHY supports stopping clock during LPI Florian Fainelli
2017-03-27 20:31 ` Andrew Lunn
2017-03-27 18:47 ` Florian Fainelli [this message]
2017-03-27 20:38 ` [PATCH RFC net-next 3/3] net: phy: stop the PHY clock during LPI only if supported Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327184721.30275-4-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox