From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, rmk+kernel@armlinux.org.uk
Subject: Re: [PATCH RFC net-next 3/3] net: phy: stop the PHY clock during LPI only if supported
Date: Mon, 27 Mar 2017 22:38:03 +0200 [thread overview]
Message-ID: <20170327203803.GH17041@lunn.ch> (raw)
In-Reply-To: <20170327184721.30275-4-f.fainelli@gmail.com>
On Mon, Mar 27, 2017 at 11:47:21AM -0700, Florian Fainelli wrote:
> Now that we detect whether a PHY supports stopping its clock during LPI,
> deny a call to phy_init_eee() with clk_stop_enable being set and the PHY
> not supporting that.
Hi Florian
We are not denying the call. This just ignores the clk_stop_enable
parameter if the clock cannot be stopped. So i think this message
could be better worded.
Maybe also update the function comment?
* and it programs the MMD register 3.0 setting the "Clock stop enable"
* bit if supported by the device.
Andrew
prev parent reply other threads:[~2017-03-27 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 18:47 [PATCH RFC net-next 0/3] net: phy: Read if PHY can stop its clock Florian Fainelli
2017-03-27 18:47 ` [PATCH RFC net-next 1/3] net: mdio: add definition for MDIO_STAT1_CLOCK_STOP_CAPABLE Florian Fainelli
2017-03-27 18:47 ` [PATCH RFC net-next 2/3] net: phy: read whether PHY supports stopping clock during LPI Florian Fainelli
2017-03-27 20:31 ` Andrew Lunn
2017-03-27 18:47 ` [PATCH RFC net-next 3/3] net: phy: stop the PHY clock during LPI only if supported Florian Fainelli
2017-03-27 20:38 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327203803.GH17041@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox