From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next 0/8] Add support for pipeline debug (dpipe) Date: Tue, 28 Mar 2017 08:51:11 +0200 Message-ID: <20170328065111.GA1873@nanopsycho.orion> References: <1490427342-2061-1-git-send-email-jiri@resnulli.us> <20170327.154834.1733255928137862540.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, arkadis@mellanox.com, idosch@mellanox.com, mlxsw@mellanox.com, jhs@mojatatu.com, ivecera@redhat.com, roopa@cumulusnetworks.com, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, john.fastabend@gmail.com, andrew@lunn.ch, simon.horman@netronome.com To: David Miller Return-path: Received: from mail-wr0-f180.google.com ([209.85.128.180]:34296 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754462AbdC1Gvf (ORCPT ); Tue, 28 Mar 2017 02:51:35 -0400 Received: by mail-wr0-f180.google.com with SMTP id l43so88422281wre.1 for ; Mon, 27 Mar 2017 23:51:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170327.154834.1733255928137862540.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Mar 28, 2017 at 12:48:34AM CEST, davem@davemloft.net wrote: > >Please fix up these warnings and resubmit: > >drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function ‘mlxsw_sp_rif_counter_free’: >drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:208:2: warning: ‘p_counter_index’ may be used uninitialized in this function [-Wmaybe-uninitialized] > mlxsw_sp_rif_counter_edit(mlxsw_sp, rif->rif_index, > ^ >drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function ‘mlxsw_sp_table_erif_entries_dump’: >drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:220:9: warning: missing braces around initializer [-Wmissing-braces] > struct devlink_dpipe_value match_value = {0}, action_value = {0}; I know about this warning. I believe that it is a gcc bug. It happens for gcc 4, but gcc 6 is silent, therefore I choose to ignore this. Do you still want me to fix it? > ^ >drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:220:9: warning: (near initialization for ‘match_value.’) [-Wmissing-braces] >drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:220:9: warning: missing braces around initializer [-Wmissing-braces] >drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:220:9: warning: (near initialization for ‘action_value.’) [-Wmissing-braces]