From: David Miller <davem@davemloft.net>
To: g.nault@alphalink.fr
Cc: netdev@vger.kernel.org, jchapman@katalix.com
Subject: Re: [PATCH net] l2tp: purge socket queues in the .destruct() callback
Date: Wed, 29 Mar 2017 09:27:07 -0700 (PDT) [thread overview]
Message-ID: <20170329.092707.886770535007645317.davem@davemloft.net> (raw)
In-Reply-To: <bf0b71ec6a771f4af715573c340dd2a83b4f02b7.1490769866.git.g.nault@alphalink.fr>
From: Guillaume Nault <g.nault@alphalink.fr>
Date: Wed, 29 Mar 2017 08:45:29 +0200
> The Rx path may grab the socket right before pppol2tp_release(), but
> nothing guarantees that it will enqueue packets before
> skb_queue_purge(). Therefore, the socket can be destroyed without its
> queues fully purged.
>
> Fix this by purging queues in pppol2tp_session_destruct() where we're
> guaranteed nothing is still referencing the socket.
>
> Fixes: 9e9cb6221aa7 ("l2tp: fix userspace reception on plain L2TP sockets")
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Applied.
next prev parent reply other threads:[~2017-03-29 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 6:45 [PATCH net] l2tp: purge socket queues in the .destruct() callback Guillaume Nault
2017-03-29 16:27 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-28 13:32 [PATCH net] l2tp: hold tunnel socket when handling control frames in l2tp_ip and l2tp_ip6 Guillaume Nault
2017-03-28 13:32 ` [PATCH net] l2tp: purge socket queues in the .destruct() callback Guillaume Nault
2017-03-29 4:39 ` David Miller
2017-03-29 6:37 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329.092707.886770535007645317.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).