From: Stefan Hajnoczi <stefanha@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jorgen Hansen <jhansen@vmware.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Adit Ranadive <aditr@vmware.com>,
George Zhang <georgezhang@vmware.com>,
Julia Lawall <julia.lawall@lip6.fr>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value
Date: Wed, 29 Mar 2017 19:35:58 +0100 [thread overview]
Message-ID: <20170329183558.GA18142@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170329153355.17525-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Wed, Mar 29, 2017 at 04:33:55PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Rather than assign the positive errno values to ret and then
> checking if it is positive and flip the sign, just return the
> errno value.
>
> Detected by CoverityScan, CID#986649 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/vmw_vsock/vmci_transport.c | 22 +++++++---------------
> 1 file changed, 7 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-03-29 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:33 [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value Colin King
2017-03-29 18:35 ` Stefan Hajnoczi [this message]
2017-03-30 13:18 ` Jorgen S. Hansen
2017-03-30 13:22 ` Michael S. Tsirkin
2017-03-30 18:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329183558.GA18142@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=aditr@vmware.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=georgezhang@vmware.com \
--cc=jhansen@vmware.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).